Skip to content

Add success and failure count OTel metrics for async shard fetch#15976

Merged
shwetathareja merged 9 commits intoopensearch-project:mainfrom
rahulkarajgikar:asf_metrics
Sep 30, 2024
Merged

Add success and failure count OTel metrics for async shard fetch#15976
shwetathareja merged 9 commits intoopensearch-project:mainfrom
rahulkarajgikar:asf_metrics

Conversation

@rahulkarajgikar
Copy link
Copy Markdown
Contributor

@rahulkarajgikar rahulkarajgikar commented Sep 18, 2024

Description

This change adds failure count and success count OTel metrics for async shard fetch

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 75e6009: SUCCESS

@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 065ba11: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 48e9fa2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for cfb40f1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rahulkarajgikar
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for cfb40f1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

failing tests:
org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting
org.opensearch.index.ShardIndexingPressureSettingsIT.classMethod
org.opensearch.indices.settings.SearchOnlyReplicaIT.testFailoverWithSearchReplica_WithoutWriterReplicas
org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

#14331 - ShardIndexingPressureSettingsIT
#15812 - SearchOnlyReplicaIT
#15806 - DedicatedClusterSnapshotRestoreIT

verified these 4 tests have showed up in flaky test report

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 6ad6c29: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (0dba562) to head (22db7ef).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ices/shards/TransportIndicesShardStoresAction.java 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15976      +/-   ##
============================================
- Coverage     72.00%   71.98%   -0.02%     
- Complexity    64487    64512      +25     
============================================
  Files          5288     5288              
  Lines        301419   301438      +19     
  Branches      43549    43552       +3     
============================================
- Hits         217026   216994      -32     
- Misses        66587    66650      +63     
+ Partials      17806    17794      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulkarajgikar rahulkarajgikar changed the title Add total and failure count OTel metrics for async shard fetch Add success and failure count OTel metrics for async shard fetch Sep 25, 2024
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for bd80ae6: SUCCESS

Rahul Karajgikar added 7 commits September 30, 2024 10:35
Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for a4ec644: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 22db7ef: SUCCESS

@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Sep 30, 2024
@shwetathareja shwetathareja merged commit 8ddb3ee into opensearch-project:main Sep 30, 2024
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15976-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ddb3eeee00978913fedd5aa49a84e718538ddae
# Push it to GitHub
git push --set-upstream origin backport/backport-15976-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15976-to-2.x.

rahulkarajgikar added a commit to rahulkarajgikar/OpenSearch that referenced this pull request Sep 30, 2024
…nsearch-project#15976)

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
(cherry picked from commit 8ddb3ee)
@rahulkarajgikar
Copy link
Copy Markdown
Contributor Author

shwetathareja pushed a commit that referenced this pull request Sep 30, 2024
) (#16130)

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
(cherry picked from commit 8ddb3ee)
hainenber pushed a commit to hainenber/OpenSearch that referenced this pull request Oct 1, 2024
ruai0511 pushed a commit to ruai0511/OpenSearch that referenced this pull request Oct 4, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch backport-failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants