add request failure listener to track failures at query group level by kaushalmahi12 · Pull Request #15527 · opensearch-project/OpenSearch

kaushalmahi12 · 2024-08-30T16:07:02Z

Author: Kaushal Kumar

Description

This change adds logic to track failures at query group level for co-ordinator search requests.

Related Issues

Resolves #15120

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

github-actions · 2024-08-30T16:59:14Z

❌ Gradle check result for 3574e3c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-30T17:09:13Z

❌ Gradle check result for 3cbe8bb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-30T17:14:34Z

❌ Gradle check result for e4e697b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-30T17:29:27Z

✅ Gradle check result for 2e4be6f: SUCCESS

codecov · 2024-08-30T17:30:06Z

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (1d5082e) to head (f3b73bd).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...java/org/opensearch/wlm/stats/QueryGroupState.java	60.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15527      +/-   ##
============================================
- Coverage     72.01%   71.92%   -0.09%     
+ Complexity    63603    63590      -13     
============================================
  Files          5247     5247              
  Lines        297186   297352     +166     
  Branches      42939    42981      +42     
============================================
- Hits         214023   213875     -148     
- Misses        65610    65849     +239     
- Partials      17553    17628      +75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/src/main/java/org/opensearch/wlm/listeners/WorkloadManagementRequestFailureListener.java

server/src/main/java/org/opensearch/wlm/stats/QueryGroupStats.java

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

github-actions · 2024-08-30T18:24:37Z

❌ Gradle check result for fd8f3f5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

github-actions · 2024-08-30T19:19:27Z

❌ Gradle check result for d89422b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-30T19:55:38Z

✅ Gradle check result for 59952e4: SUCCESS

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

github-actions · 2024-08-30T20:45:14Z

✅ Gradle check result for f3b73bd: SUCCESS

opensearch-trigger-bot · 2024-08-30T21:08:25Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15527-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 579f2aaef81cdee80028fceba1f509dc69e108c6
# Push it to GitHub
git push --set-upstream origin backport/backport-15527-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15527-to-2.x.

…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add workload managementRequestFailureListener * add unit tests * add CHANGELOG * add missing javadoc * refactor * address comments * rename listener instance --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

…oject#15527) * add workload managementRequestFailureListener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add unit tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename listener instance Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

kaushalmahi12 added 3 commits August 29, 2024 17:12

add workload managementRequestFailureListener

81b7a07

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

Merge branch 'main' into feature/sandbox-failure_listener

2885216

add unit tests

3574e3c

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

github-actions bot added Meta Meta issue, not directly linked to a PR Search Search query, autocomplete ...etc labels Aug 30, 2024

kaushalmahi12 added the backport 2.x Backport to 2.x branch label Aug 30, 2024

kaushalmahi12 added 2 commits August 30, 2024 09:16

add CHANGELOG

3cbe8bb

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

Merge branch 'main' into feature/sandbox-failure_listener

e4e697b

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

add missing javadoc

2e4be6f

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

jainankitk reviewed Aug 30, 2024

View reviewed changes

server/src/main/java/org/opensearch/wlm/listeners/WorkloadManagementRequestFailureListener.java Outdated Show resolved Hide resolved

jainankitk reviewed Aug 30, 2024

View reviewed changes

server/src/main/java/org/opensearch/wlm/stats/QueryGroupStats.java Outdated Show resolved Hide resolved

refactor

fd8f3f5

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

kaushalmahi12 added 2 commits August 30, 2024 11:40

address comments

d89422b

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

rename listener instance

59952e4

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

Merge branch 'main' into feature/sandbox-failure_listener

f3b73bd

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

jainankitk approved these changes Aug 30, 2024

View reviewed changes

jainankitk merged commit 579f2aa into opensearch-project:main Aug 30, 2024

opensearch-trigger-bot bot added the backport-failed label Aug 30, 2024

kaushalmahi12 mentioned this pull request Aug 30, 2024

[Backport 2.x] add request failure listener to track failures at query group level (#15527) #15539

Merged

opensearch-ci-bot mentioned this pull request Sep 11, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT #14294

Open

BrewTestBot mentioned this pull request Sep 18, 2024

opensearch 2.17.0 Homebrew/homebrew-core#191052

Merged

prudhvigodithi mentioned this pull request Oct 16, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT prudhvigodithi/opensearch-build#82

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add request failure listener to track failures at query group level#15527

add request failure listener to track failures at query group level#15527
jainankitk merged 10 commits intoopensearch-project:mainfrom
kaushalmahi12:feature/sandbox-failure_listener

kaushalmahi12 commented Aug 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

codecov bot commented Aug 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

opensearch-trigger-bot bot commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kaushalmahi12 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

codecov bot commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

opensearch-trigger-bot bot commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kaushalmahi12 commented Aug 30, 2024 •

edited

Loading

codecov bot commented Aug 30, 2024 •

edited

Loading