Skip to content

Add slice level operation listener methods#15153

Merged
jed326 merged 1 commit intoopensearch-project:mainfrom
jed326:slice-listener
Aug 8, 2024
Merged

Add slice level operation listener methods#15153
jed326 merged 1 commit intoopensearch-project:mainfrom
jed326:slice-listener

Conversation

@jed326
Copy link
Copy Markdown
Contributor

@jed326 jed326 commented Aug 7, 2024

Description

Add slice level operation listener to SearchOperationListener plugin interface. See motivation in #15136.

Related Issues

Resolves #15136

Check List

  • Functionality includes testing.
    - [ ] API changes companion pull request created, if applicable.
    - [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions Bot added enhancement Enhancement or improvement to existing feature or request Roadmap:Search Project-wide roadmap label Search:Performance labels Aug 7, 2024
@jed326 jed326 added the backport 2.x Backport to 2.x branch label Aug 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 7, 2024

❌ Gradle check result for 1770e61: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 7, 2024

❌ Gradle check result for 9ded024: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 7, 2024

❌ Gradle check result for 32a0ea7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2024

❌ Gradle check result for f27d3d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326
Copy link
Copy Markdown
Contributor Author

jed326 commented Aug 8, 2024

Comment thread server/src/main/java/org/opensearch/index/shard/SearchOperationListener.java Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2024

✅ Gradle check result for f27d3d9: SUCCESS

Signed-off-by: Jay Deng <jayd0104@gmail.com>
@jed326 jed326 requested a review from linuxpi as a code owner August 8, 2024 21:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2024

✅ Gradle check result for a02230d: SUCCESS

@jed326 jed326 added the v2.17.0 label Aug 8, 2024
@jed326 jed326 merged commit 978d14e into opensearch-project:main Aug 8, 2024
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Aug 8, 2024
Signed-off-by: Jay Deng <jayd0104@gmail.com>
(cherry picked from commit 978d14e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Aug 8, 2024
(cherry picked from commit 978d14e)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Roadmap:Search Project-wide roadmap label Search:Performance v2.17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Add pre/post slice execution hook to SearchOperationListener for concurrent segment search to collect search metrics & stats

4 participants