[Backport 2.x] Use default value when index.number_of_replicas is null#14906
Merged
[Backport 2.x] Use default value when index.number_of_replicas is null#14906
Conversation
* Use default value when index.number_of_replicas is null Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Add integration test Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Add changelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> --------- Signed-off-by: Liyun Xiu <xiliyun@amazon.com> (cherry picked from commit e485856) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
approved these changes
Jul 23, 2024
Contributor
|
❌ Gradle check result for 9cafa07: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14906 +/- ##
============================================
- Coverage 71.60% 71.53% -0.08%
+ Complexity 62639 62569 -70
============================================
Files 5117 5117
Lines 293941 293942 +1
Branches 42834 42835 +1
============================================
- Hits 210466 210258 -208
- Misses 65813 66007 +194
- Partials 17662 17677 +15 ☔ View full report in Codecov by Sentry. |
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…roject#14812) (opensearch-project#14906) * Use default value when index.number_of_replicas is null * Add integration test * Add changelog --------- (cherry picked from commit e485856) Signed-off-by: Liyun Xiu <xiliyun@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport e485856 from #14812.