Skip to content

fix FuzzyQuery in keyword field will use IndexOrDocValuesQuery when both of index and doc_value are true#14378

Merged
andrross merged 4 commits intoopensearch-project:mainfrom
kkewwei:issue_14377
Jun 24, 2024
Merged

fix FuzzyQuery in keyword field will use IndexOrDocValuesQuery when both of index and doc_value are true#14378
andrross merged 4 commits intoopensearch-project:mainfrom
kkewwei:issue_14377

Conversation

@kkewwei
Copy link
Copy Markdown
Contributor

@kkewwei kkewwei commented Jun 15, 2024 •
edited
Loading

Description

Fix FuzzyQuery in keyword field will use IndexOrDocValuesQuery when both of index and doc_value are true.

Related Issues

Resolves #14377

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions Bot added bug Something isn't working Search Search query, autocomplete ...etc labels Jun 15, 2024
@kkewwei
Copy link
Copy Markdown
Contributor Author

kkewwei commented Jun 15, 2024

@harshavamsi @msfroh, please help review the code when you are free, I am very grateful for this.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 15, 2024

✅ Gradle check result for d843cdd: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (b15cb0c) to head (5e7ab2a).
Report is 475 commits behind head on main.

Files Patch % Lines
...a/org/opensearch/index/mapper/StringFieldType.java 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14378      +/-   ##
============================================
+ Coverage     71.42%   71.66%   +0.24%     
- Complexity    59978    62152    +2174     
============================================
  Files          4985     5125     +140     
  Lines        282275   292352   +10077     
  Branches      40946    42243    +1297     
============================================
+ Hits         201603   209526    +7923     
- Misses        63999    65538    +1539     
- Partials      16673    17288     +615

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 15, 2024

✅ Gradle check result for c873c43: SUCCESS

@kkewwei kkewwei changed the title fix fix FuzzyQuery in keyword will use IndexOrDocValuesQuery when both of index and doc_value are true fix FuzzyQuery in keyword will use IndexOrDocValuesQuery when both of index and doc_value are true Jun 16, 2024
@kkewwei kkewwei mentioned this pull request Jun 16, 2024
Merged
3 tasks
@kkewwei
Copy link
Copy Markdown
Contributor Author

kkewwei commented Jun 18, 2024 •
edited
Loading

@dblock, please have a another look when you are free.

dblock
dblock previously requested changes Jun 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this code, maybe @andrross or someone else is?

Comment thread server/src/main/java/org/opensearch/index/mapper/StringFieldType.java
@kkewwei
Merge branch 'main' into issue_14377
2326e62 
Signed-off-by: kkewwei <kkewwei@163.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024

✅ Gradle check result for 2326e62: SUCCESS

@kkewwei
Copy link
Copy Markdown
Contributor Author

kkewwei commented Jun 20, 2024

@andrross please help merge, thank you.

@kkewwei
Merge branch 'main' into issue_14377
ba4b35f 
Signed-off-by: kkewwei <kkewwei@163.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 21, 2024

✅ Gradle check result for ba4b35f: SUCCESS

@kkewwei
Merge branch 'main' into issue_14377
5e7ab2a 
Signed-off-by: kkewwei <kkewwei@163.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 22, 2024

❌ Gradle check result for 5e7ab2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Copy Markdown
Contributor Author

kkewwei commented Jun 23, 2024

❌ Gradle check result for 5e7ab2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchWithRandomExceptionsIT.testRandomExceptions #14144

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 24, 2024

❌ Gradle check result for 5e7ab2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 24, 2024
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 24, 2024

✅ Gradle check result for 5e7ab2a: SUCCESS

@andrross andrross dismissed dblock’s stale review June 24, 2024 21:42

Looks good to me

@andrross andrross merged commit afad5eb into opensearch-project:main Jun 24, 2024
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Jun 24, 2024
@github-actions
Fix FuzzyQuery in keyword field when both of index and doc_value are …
2e26915 
…true (#14378)

Signed-off-by: kkewwei <kkewwei@163.com>
(cherry picked from commit afad5eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request Jun 24, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 25, 2024
Open
jed326 pushed a commit that referenced this pull request Jun 25, 2024
@opensearch-trigger-bot @github-actions
Fix FuzzyQuery in keyword field when both of index and doc_value are …
8f92e56 
…true (#14378) (#14529)

(cherry picked from commit afad5eb)

Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
@kkewwei @harshavamsi
Fix FuzzyQuery in keyword field when both of index and doc_value are …
9987c96 
…true (opensearch-project#14378)

Signed-off-by: kkewwei <kkewwei@163.com>
@finnegancarroll finnegancarroll mentioned this pull request Jul 15, 2024
Closed
3 tasks
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Fix FuzzyQuery in keyword field when both of index and doc_value are …
94fd59b 
…true (opensearch-project#14378) (opensearch-project#14529)

(cherry picked from commit afad5eb)

Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@kkewwei
Fix FuzzyQuery in keyword field when both of index and doc_value are …
5db5a74 
…true (opensearch-project#14378)

Signed-off-by: kkewwei <kkewwei@163.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Closed
@kkewwei kkewwei deleted the issue_14377 branch September 19, 2024 02:29
@tkykenmt tkykenmt mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

+2 more reviewers

@harshavamsi harshavamsi harshavamsi approved these changes

@dblock dblock dblock left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x Backport to 2.x branch bug Something isn't working Search Search query, autocomplete ...etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] FuzzyQuery in keyword type does not use the IndexOrDocValuesQuery when index is and doc_value is true

4 participants

@kkewwei @dblock @andrross @harshavamsi