Implement missing methods for EncryptedBlobStore and EncryptedBlobContainer#14030
Conversation
|
❌ Gradle check result for 1be954e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1be954e to
9e924dc
Compare
|
❌ Gradle check result for 9e924dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9e924dc to
9c4ac19
Compare
|
❌ Gradle check result for 9c4ac19: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9c4ac19 to
84b523e
Compare
|
❌ Gradle check result for 84b523e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…tainer Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
84b523e to
a1b612b
Compare
|
❕ Gradle check result for a1b612b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14030 +/- ##
============================================
+ Coverage 71.42% 71.63% +0.20%
- Complexity 59978 61395 +1417
============================================
Files 4985 5071 +86
Lines 282275 288407 +6132
Branches 40946 41764 +818
============================================
+ Hits 201603 206586 +4983
- Misses 63999 64767 +768
- Partials 16673 17054 +381 ☔ View full report in Codecov by Sentry. |
ashking94
left a comment
There was a problem hiding this comment.
Can we see if we can add UTs atleast for this change?
|
❌ Gradle check result for 3233952: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3233952 to
54147fd
Compare
|
❌ Gradle check result for 54147fd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
54147fd to
83035db
Compare
|
❌ Gradle check result for 83035db: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
83035db to
60f4594
Compare
ashking94
left a comment
There was a problem hiding this comment.
thanks for adding the tests.
…tainer (opensearch-project#14030) Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
…tainer (opensearch-project#14030) (opensearch-project#14114) (cherry picked from commit 270054c) Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
…tainer (opensearch-project#14030) Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Description
Implement missing methods IsBlobMetadataEnabled(), readBlobWithMetadata() for EncryptedBlobStore and EncryptedBlobContainer. These methods were introduced as part of #13091
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.