Skip to content

Replace JCenter with Maven Central.#1057

Merged
adnapibar merged 1 commit intoopensearch-project:mainfrom
adnapibar:maven-central
Aug 10, 2021
Merged

Replace JCenter with Maven Central.#1057
adnapibar merged 1 commit intoopensearch-project:mainfrom
adnapibar:maven-central

Conversation

@adnapibar
Copy link
Copy Markdown
Contributor

Description

https://blog.gradle.org/jcenter-shutdown

Issues Resolved

#1055

Check List

  • All tests pass
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda adnapibar@gmail.com

Replace with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar added the v2.0.0 Version 2.0.0 label Aug 6, 2021
Comment thread buildSrc/build.gradle
repositories {
jcenter()
mavenCentral()
gradlePluginPortal()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For plugins not in mavenCentral() as a fallback. The Gradle Plugin Portal implicitly mirrors JCenter currently.

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Wrapper Validation success ff06789

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   DCO Check Passed ff06789

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Precommit success ff06789

@adnapibar
Copy link
Copy Markdown
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Check success ff06789
Log 376

Reports 376

Copy link
Copy Markdown
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On what dependencies of OpenSearch, we rely on jcenter() today?

I do not see any specific dependency from jcenter() which cannot be fetched from mavenCentral() for OpenSearch, curious why it was added.

@adnapibar
Copy link
Copy Markdown
Contributor Author

On what dependencies of OpenSearch, we rely on jcenter() today?

I do not see any specific dependency from jcenter() which cannot be fetched from mavenCentral() for OpenSearch, curious why it was added.

All dependencies are resolved through jcenter today. This change removes that and uses mavenCentral instead.

@saratvemulapalli
Copy link
Copy Markdown
Member

On what dependencies of OpenSearch, we rely on jcenter() today?
I do not see any specific dependency from jcenter() which cannot be fetched from mavenCentral() for OpenSearch, curious why it was added.

All dependencies are resolved through jcenter today. This change removes that and uses mavenCentral instead.

Thanks for helping me understand. It would be nice to see this as description for the PR.

@adnapibar
Copy link
Copy Markdown
Contributor Author

Thanks for helping me understand. It would be nice to see this as description for the PR.

Thanks:) The linked issue has all the details.

@adnapibar adnapibar linked an issue Aug 10, 2021 that may be closed by this pull request
@adnapibar adnapibar merged commit e78040a into opensearch-project:main Aug 10, 2021
krishna-ggk pushed a commit to saikaranam-amazon/OpenSearch that referenced this pull request Sep 16, 2021
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar deleted the maven-central branch December 26, 2021 18:37
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 12, 2022
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
CEHENKLE pushed a commit that referenced this pull request Jan 12, 2022
… plugin repository order. (#1894)

* Replace JCenter with Maven Central. (#1057)

On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Define plugin repositories order in settings.gradle.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Co-authored-by: Rabi Panda <adnapibar@gmail.com>
CEHENKLE pushed a commit that referenced this pull request Jan 13, 2022
On February 3 2021, JFrog [announced](https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/) the shutdown of JCenter. Later on April 27 2021, an update was provided that the repository will only be read only and new package and versions are no longer accepted on JCenter.  This means we should no longer use JCenter for our central artifacts repository.

This change replaces JCenter with Maven Central as per the Gradle recommendation - https://blog.gradle.org/jcenter-shutdown

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>

Co-authored-by: Rabi Panda <adnapibar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2.0.0 Version 2.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace JCenter with Maven Central for Gradle Build

3 participants