[#3420] disable autocomplete on hide - pt.2#3429
Merged
t-paul merged 3 commits intoopenscad:masterfrom Sep 6, 2020
Merged
Conversation
Fixes instance of: 1. Editor visible. Type `cu`. 2. Hide editor 3. Type `b`.
Fixes instance of typing `cube(`, hiding the editor and then typing `(`
https://www.scintilla.org/ScintillaDoc.html#SCI_CALLTIPCANCEL exists but isn't part of the C++ class for some reason.
Member
|
Thanks for taking care of those cases too. To me it's really surprising all of that is needed, showing the popups on a read-only editor seems like a bug in the editor code. |
t-paul
approved these changes
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hadn't thought to test additional text input after setting the editor to read only, thought that would already block everything, my bad. Thanks for the comments and sorry for the delay!
Second PR addressing: #3420
First PR: #3423