[#3420] disable editor when hidden#3423
Conversation
t-paul
left a comment
There was a problem hiding this comment.
I think that's actually a Qt bug. It might even be fixed as I can't reproduce the issue on Debian/Testing with Qt5.14.2. There's a similar sounding issue https://bugreports.qt.io/browse/QTBUG-82939 which is still open.
As a number of builds use older Qt versions and are affected by the issue, it seems sensible to have this fix, it would just be nice to have a code comment on why this code is here and that it is likely a workaround.
|
Nice find! Looks like the exact issue. Huh, so you can't reproduce it? That's weird, on that ticket it says it affects version 5.14.1 and my local is using 5.15.0 . Not too sure what's going on. For the comments, is this alright? 8624880 |
|
I'm still puzzled why it does not happen with my local build. It does happen with the Snap package. I do run Wayland but OpenSCAD is not running as native Wayland app. Anyway, the patch looks good. Thanks. |
|
Hmm, looks like the updated snap does not fix the issue. |
|
Should there be Windows builds there? |
|
Those should show up automatically on the download page at about 8 EDT. |
|
Has the build changed or is it sill running?
and the files accessed via artifacts. |
|
Oh, on the PR. Not sure why, but it looks like CircleCI did not see that PR at all. It's been a bit problematic for a while now. Other PRs just start showing "Unauthorized" and fail to run too, but I can trigger manually. |
|
Looking again at the Snap it does make the editor read-only. It still triggers the autocomplete though, e.g. by typing |
|
And it's possible to trigger call-tips via |
Addresses #3420