Fix terminal code copy #1461
Merged
Fix terminal code copy #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying opensafely-docs with
|
| Latest commit: |
65f0c9f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://15973e4f.opensafely-docs.pages.dev |
| Branch Preview URL: | https://jongmassey-fix-terminal-code.opensafely-docs.pages.dev |
5d2dab4 to
5a8f13a
Compare
5a8f13a to
578992d
Compare
tomodwyer
approved these changes
Mar 15, 2024
43 tasks
eth3lbert
added a commit
to eth3lbert/uv
that referenced
this pull request
Jul 24, 2024
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Jul 31, 2024
## Summary This PR improves the copy of the console command example by: - Preventing the selection of generic prompts and generic output - Lazily setting copy content by leveraging intersection observer Most of the changes are inspired by opensafely/documentation#1461 Some other useful refs: - squidfunk/mkdocs-material#3647 - https://mkdocstrings.github.io/recipes/#prevent-selection-of-prompts-and-output-in-python-code-blocks Resolves #5355 ## Test Plan - ``` shell-session mkdocs serve -f mkdocs.public.yml ``` - Navigate to http://localhost:8000/uv/first-steps/#viewing-the-version - Try clicking the copy button - Try copying by selecting the content --------- Co-authored-by: Zanie Blue <contact@zanie.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1458
>>>and any output lines from copied text when copy button is clicked on a Python code block$and any output lines from copied text when copy button is clicked on a Shell code block