ReplaceWeekYearWithYear should not replace valid week-year usages#801
Merged
timtebeek merged 3 commits intoopenrewrite:mainfrom Jan 3, 2026
Conversation
- Failing test case for ReplaceWeekYearWithYear when used with week-year and week of year
Member
|
Great to see, thanks! Sharing the notes you left on the commit here as well to make those easier to find:
|
ReplaceWeekYearWithYear should not replace valid week-year usages
timtebeek
approved these changes
Jan 3, 2026
Member
timtebeek
left a comment
There was a problem hiding this comment.
Thanks for the help here @tginsberg ; Nice simplification & bug fix. Guess this was the best week of the year for discovery & fix. All the best there!
Contributor
Author
|
Thanks for making contributing so easy @timtebeek! I was writing a blog post on week year and was covering how to fix it and noticed this aspect of the rule. I figured it was a good chance to contribute, in a small way, to a project I admire so much. Thanks for accepting my fix! :) |
Member
|
Thanks for the kind words & help! Linking your post here for others interested as well: We'll put out a new release in the coming days that contains your fix. |
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Jan 9, 2026
… 2.24.0 to 2.25.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.24.0 to 2.25.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).* > 2.25.0 > ------ > > What's Changed > -------------- > > * `ReplaceWeekYearWithYear` should not replace valid week-year usages by [`@tginsberg`](https://github.com/tginsberg) in [openrewrite/rewrite-static-analysis#801](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/801) > > New Contributors > ---------------- > > * [`@tginsberg`](https://github.com/tginsberg) made their first contribution in [openrewrite/rewrite-static-analysis#801](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/801) > > **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.24.0...v2.25.0> Commits * [`f51717c`](openrewrite/rewrite-static-analysis@f51717c) Extract documentation examples from tests * [`57ea9bb`](openrewrite/rewrite-static-analysis@57ea9bb) Update documentation examples * [`736160d`](openrewrite/rewrite-static-analysis@736160d) Minimize duplicate logic & traversal in `NestedEnumsAreNotStatic` * [`2a88748`](openrewrite/rewrite-static-analysis@2a88748) `ReplaceWeekYearWithYear` should not replace valid week-year usages ([#801](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/801)) * [`e552501`](openrewrite/rewrite-static-analysis@e552501) Update recipe documentation examples * [`7529320`](openrewrite/rewrite-static-analysis@7529320) Generate a recipes.csv for the recipes defined in this repository * See full diff in [compare view](openrewrite/rewrite-static-analysis@v2.24.0...v2.25.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
This is a failing test case against issue #800
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist