Fix RemoveUnusedLocalVariables to delete unused local variables inside method invocation argument blocks by Jenson3210 · Pull Request #795 · openrewrite/rewrite-static-analysis

Jenson3210 · 2025-11-28T11:19:00Z

Fix RemoveUnusedLocalVariables to delete unused local variables inside method invocation argument blocks(lambdas, anonymous classes...) to avoid ClassCastException.

introduced since: RemoveUnusedLocalVariables keeps assignement of unused variable, but removes its declaration rewrite#1743

Without this fix the code would unwrap

                      consumer(() -> {
                          String removeMeLiteral;
                          String removeMeIdentifier;
                          String bar = "abc";
                          removeMeLiteral = "123";
                          removeMeIdentifier = bar;
                          return bar;
                      });

in the PruneAssignmentExpression$visitMethodInvocation and replace both removeMeLiteral = "123" and removeMeIdentifier = bar; to "123" and bar. This is then throwing ClassCastException when the DeleteStatement postVisit tries to visit the block and finds a JRighPadded<Identifier|Literal> where the assignment used to be and then throws ClassCastException as these are not Statements.

https://github.com/openrewrite/rewrite/blob/8986f6fa1ca2355cd578d4fd8f39e7197a9cc490/rewrite-gradle/src/main/java/org/openrewrite/gradle/ChangeDependencyClassifier.java#L169 has an unused variable. It is wrapped in a Preconditions.check methodInvocation in a anonymous class block

fix RemoveUnusedLocalVariables crashes when unused variable is within some method invocation #786

…e method invocation argument blocks (lambdas, anonymous classes...) to avoid ClassCastException

greg-at-moderne · 2025-11-28T11:21:34Z

Related to RemoveUnusedLocalVariables crashes when unused variable is within some method invocation #786

… 2.22.0 to 2.23.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.22.0 to 2.23.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).* > 2.23.0 > ------ > > What's Changed > -------------- > > * Prepare formatting refactor by [`@Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-static-analysis#790](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/790) > * Fix `AnnotateRequiredParameters` to handle `Objects.requireNonNull` in assignments by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#793](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/793) > * `AnnotateRequiredParameters` should not remove nested if blocks by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#794](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/794) > * Fix RemoveUnusedLocalVariables to delete unused local variables inside method invocation argument blocks by [`@Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-static-analysis#795](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/795) > > **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.22.0...v2.23.0> Commits * [`cc90fe8`](openrewrite/rewrite-static-analysis@cc90fe8) Fix RemoveUnusedLocalVariables to delete unused local variables inside method... * [`e98aef6`](openrewrite/rewrite-static-analysis@e98aef6) `AnnotateRequiredParameters` should not remove nested if blocks ([#794](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/794)) * [`65b6188`](openrewrite/rewrite-static-analysis@65b6188) Fix `AnnotateRequiredParameters` to handle `Objects.requireNonNull` in assign... * [`df434ea`](openrewrite/rewrite-static-analysis@df434ea) Gradle wrapper 9.2.1 * [`6eab4c9`](openrewrite/rewrite-static-analysis@6eab4c9) Prepare formatting refactor ([#790](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/790)) * See full diff in [compare view](openrewrite/rewrite-static-analysis@v2.22.0...v2.23.0) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-static-analysis&package-manager=maven&previous-version=2.22.0&new-version=2.23.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Fix RemoveUnusedLocalVariables to delete unused local variables insid…

51f8840

…e method invocation argument blocks (lambdas, anonymous classes...) to avoid ClassCastException

Jenson3210 requested a review from timtebeek November 28, 2025 11:19

Jenson3210 self-assigned this Nov 28, 2025

Jenson3210 added the bug Something isn't working label Nov 28, 2025

moderne-meeseeks bot added this to OpenRewrite Nov 28, 2025

github-project-automation bot moved this to In Progress in OpenRewrite Nov 28, 2025

timtebeek approved these changes Nov 28, 2025

View reviewed changes

github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Nov 28, 2025

timtebeek merged commit cc90fe8 into main Nov 28, 2025
2 checks passed

timtebeek deleted the fix-recipe-alert branch November 28, 2025 11:32

github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Nov 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix RemoveUnusedLocalVariables to delete unused local variables inside method invocation argument blocks#795

Fix RemoveUnusedLocalVariables to delete unused local variables inside method invocation argument blocks#795
timtebeek merged 1 commit intomainfrom
fix-recipe-alert

Jenson3210 commented Nov 28, 2025 •

edited

Loading

Uh oh!

greg-at-moderne commented Nov 28, 2025 •

edited by timtebeek

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Jenson3210 commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greg-at-moderne commented Nov 28, 2025 • edited by timtebeek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jenson3210 commented Nov 28, 2025 •

edited

Loading

greg-at-moderne commented Nov 28, 2025 •

edited by timtebeek

Loading