Convert assigning Switch statements to Switch expressions by pdelagrave · Pull Request #795 · openrewrite/rewrite-migrate-java

pdelagrave · 2025-07-14T18:58:55Z

What's changed?

A new recipe to convert switch statements for which all cases are doing an assignment to the same variable into a switch expression that is assigned to that variable:

From:

       String formatted = "initialValue";
       switch (obj) {
            case Integer i -> formatted = String.format("int %d", i);
            case Long l -> formatted = String.format("long %d", l);
            default -> formatted = "unknown";
       }

To:

        String formatted = switch (obj) {
            case Integer i -> String.format("int %d", i);
            case Long l -> String.format("long %d", l);
            default -> "unknown";
        }

What's your motivation?

Closes Convert assigning Switch statements to Switch expressions #718

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

I've added unit tests to cover both positive and negative cases
I've read and applied the recipe conventions and best practices
I've used the IntelliJ IDEA auto-formatter on affected files

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/java/migrate/lang/NullCheckAsSwitchCase.java
- lines 27-27

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/java/migrate/lang/NullCheckAsSwitchCase.java
- lines 27-28

Laurens-W · 2025-07-15T09:23:44Z

Appreciate the draft with extensive tests here!
Perhaps good to disable some of the more extensive tests for now and start work on converting the simple colon/arrow into a single statement/expression cases!

src/main/java/org/openrewrite/java/migrate/lang/SwitchUtils.java

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/java/migrate/lang/NullCheckAsSwitchCase.java
- lines 27-27

src/main/resources/META-INF/rewrite/java-version-21.yml

timtebeek · 2025-07-21T23:51:52Z

Ran it against some 600 local LSTs; only saw results for a single repository: apache/maven

diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java
index 4481486..da4519e 100644
--- a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java
+++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java
@@ -30,20 +30,13 @@ org.openrewrite.java.migrate.lang.SwitchCaseAssigningToSwitchExpression
 public class LogbackConfiguration extends BaseSlf4jConfiguration {
     @Override
     public void setRootLoggerLevel(Level level) {
-        ch.qos.logback.classic.Level value;
-        switch (level) {
-            case DEBUG:
-                value = ch.qos.logback.classic.Level.DEBUG;
-                break;
+        ch.qos.logback.classic.Level value = switch (level) {
+            case DEBUG: yield ch.qos.logback.classic.Level.DEBUG;
 
-            case INFO:
-                value = ch.qos.logback.classic.Level.INFO;
-                break;
+            case INFO: yield ch.qos.logback.classic.Level.INFO;
 
-            default:
-                value = ch.qos.logback.classic.Level.ERROR;
-                break;
-        }
+            default: yield ch.qos.logback.classic.Level.ERROR;
+        };
         ((ch.qos.logback.classic.Logger) LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME)).setLevel(value);
     }
 
diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java
index 1f02e57..07e84c8 100644
--- a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java
+++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java
@@ -28,20 +28,13 @@ org.openrewrite.java.migrate.lang.SwitchCaseAssigningToSwitchExpression
 public class Log4j2Configuration extends BaseSlf4jConfiguration {
     @Override
     public void setRootLoggerLevel(Level level) {
-        String value;
-        switch (level) {
-            case DEBUG:
-                value = "debug";
-                break;
+        String value = switch (level) {
+            case DEBUG: yield "debug";
 
-            case INFO:
-                value = "info";
-                break;
+            case INFO: yield "info";
 
-            default:
-                value = "error";
-                break;
-        }
+            default: yield "error";
+        };
         System.setProperty("maven.logging.root.level", value);
     }
 
diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java
index 5147cd8..0c5f4e2 100644
--- a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java
+++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java
@@ -31,20 +31,13 @@ org.openrewrite.java.migrate.lang.SwitchCaseAssigningToSwitchExpression
 public class MavenSimpleConfiguration extends BaseSlf4jConfiguration {
     @Override
     public void setRootLoggerLevel(Level level) {
-        String value;
-        switch (level) {
-            case DEBUG:
-                value = "debug";
-                break;
+        String value = switch (level) {
+            case DEBUG: yield "debug";
 
-            case INFO:
-                value = "info";
-                break;
+            case INFO: yield "info";
 
-            default:
-                value = "error";
-                break;
-        }
+            default: yield "error";
+        };
         System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", value);
     }

Does that align with what you were seeing there?

pdelagrave · 2025-07-22T15:56:44Z

src/test/java/org/openrewrite/java/migrate/lang/SwitchCaseAssigningToSwitchExpressionTest.java

+                  void exhaustiveButCantAddDefaultAfterEmptyLabel(TrafficLight light) {
+                      String status = "initialValue";
+                      switch (light) {
+                          case RED: status = "stop"; break;
+                          case GREEN: status = "go"; break;
+                          case YELLOW:
+                      }
+                  }


@timtebeek
While the switch is already exhaustive, wouldn't still adding default: yield "initialValue"; at the end be safe and preserve the logic in any situation, given the last case is empty?
This would require a fix in the code but that new test made me wonder why not.

…h exhaustiveness on an enum switch selector

pdelagrave · 2025-07-22T21:59:10Z

Ran it against some 600 local LSTs; only saw results for a single repository: apache/maven

diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java
index 4481486..da4519e 100644
--- a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java
+++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/LogbackConfiguration.java
@@ -30,20 +30,13 @@ org.openrewrite.java.migrate.lang.SwitchCaseAssigningToSwitchExpression
 public class LogbackConfiguration extends BaseSlf4jConfiguration {
     @Override
     public void setRootLoggerLevel(Level level) {
-        ch.qos.logback.classic.Level value;
-        switch (level) {
-            case DEBUG:
-                value = ch.qos.logback.classic.Level.DEBUG;
-                break;
+        ch.qos.logback.classic.Level value = switch (level) {
+            case DEBUG: yield ch.qos.logback.classic.Level.DEBUG;
 
-            case INFO:
-                value = ch.qos.logback.classic.Level.INFO;
-                break;
+            case INFO: yield ch.qos.logback.classic.Level.INFO;
 
-            default:
-                value = ch.qos.logback.classic.Level.ERROR;
-                break;
-        }
+            default: yield ch.qos.logback.classic.Level.ERROR;
+        };
         ((ch.qos.logback.classic.Logger) LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME)).setLevel(value);
     }
 
diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java
index 1f02e57..07e84c8 100644
--- a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java
+++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/Log4j2Configuration.java
@@ -28,20 +28,13 @@ org.openrewrite.java.migrate.lang.SwitchCaseAssigningToSwitchExpression
 public class Log4j2Configuration extends BaseSlf4jConfiguration {
     @Override
     public void setRootLoggerLevel(Level level) {
-        String value;
-        switch (level) {
-            case DEBUG:
-                value = "debug";
-                break;
+        String value = switch (level) {
+            case DEBUG: yield "debug";
 
-            case INFO:
-                value = "info";
-                break;
+            case INFO: yield "info";
 
-            default:
-                value = "error";
-                break;
-        }
+            default: yield "error";
+        };
         System.setProperty("maven.logging.root.level", value);
     }
 
diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java
index 5147cd8..0c5f4e2 100644
--- a/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java
+++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java
@@ -31,20 +31,13 @@ org.openrewrite.java.migrate.lang.SwitchCaseAssigningToSwitchExpression
 public class MavenSimpleConfiguration extends BaseSlf4jConfiguration {
     @Override
     public void setRootLoggerLevel(Level level) {
-        String value;
-        switch (level) {
-            case DEBUG:
-                value = "debug";
-                break;
+        String value = switch (level) {
+            case DEBUG: yield "debug";
 
-            case INFO:
-                value = "info";
-                break;
+            case INFO: yield "info";
 
-            default:
-                value = "error";
-                break;
-        }
+            default: yield "error";
+        };
         System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", value);
     }

Does that align with what you were seeing there?

I've ran it on apache repos and got a few repos responding, but by far apache/fineract had the most changes (~34)
There were more initially (48) but we're seeing less of them as the recipe is now stricter to be safe, for example:

    EnumOptionData optionData = new EnumOptionData(AccountType.INVALID.getValue().longValue(), AccountType.INVALID.getCode(), "Invalid");
        switch (type) {
            case INVALID:
                optionData = new EnumOptionData(AccountType.INVALID.getValue().longValue(), AccountType.INVALID.getCode(), "Invalid");
...

doesn't get migrated anymore because the optionData initializer code could have a side effect and we don't want to remove it, even though in many circumstances (like this one) it would be fine.

Bhadboiab

Great job 👏

src/main/java/org/openrewrite/java/migrate/lang/SwitchUtils.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…12.0 to 3.15.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.12.0 to 3.15.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).* > 3.15.0 > ------ > > What's Changed > -------------- > > * Convert assigning Switch statements to Switch expressions by [`@pdelagrave`](https://github.com/pdelagrave) in [openrewrite/rewrite-migrate-java#795](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/795) > * Convert switch expressions to arrows where possible by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#801](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/801) > * Convert switch cases with returns to returned switch expression by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#802](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/802) > * `ReplaceStreamCollectWithToList` should look at return type by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#803](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/803) > * New recipe to adopt Lombok setter method names by [`@timo-a`](https://github.com/timo-a) in [openrewrite/rewrite-migrate-java#632](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/632) > * refactor: Static imports for Collections and Collectors by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#804](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/804) > * Preserve whitespace in `MigrateCollectionsUnmodifiableList` by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#806](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/806) > * rename settings.local.json to settings.json by [`@zieka`](https://github.com/zieka) in [openrewrite/rewrite-migrate-java#808](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/808) > * The quick fix for the tests for Jaxws Dependencies by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#809](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/809) > * Refactor RewriteTest to use defaults method by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#814](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/814) > * Create `is` methods for boolean fields in `LombokValueToRecord` by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#813](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/813) > * Joda-time: Make safe migration optional by [`@amishra-u`](https://github.com/amishra-u) in [openrewrite/rewrite-migrate-java#811](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/811) > * Improve "Add explicit Common Annotations dependencies" in "Migrate to Java 11" by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#816](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/816) > * chore(ci): bump actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-migrate-java#817](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/817) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.14.0...v3.15.0> > > 3.14.1 > ------ > > What's Changed > -------------- > > * OpenRewrite v8.59.1: <https://github.com/openrewrite/rewrite> > > **Full Changelog**: <https://github.com/openrewrite/rewrite-migrate-java> > > 3.14.0 > ------ > > What's Changed > -------------- > > * `NullCheckAsSwitchCase` should only add `null` case if the switch is exhaustive by [`@Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-migrate-java#769](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/769) > * Let all change-to-var recipes use a created var-Identifier instead of using a JavaTemplate by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#793](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/793) > * Fix NPE in IteratorNext recipe when iterator() has no explicit receiver by [`@jkschneider`](https://github.com/jkschneider) in [openrewrite/rewrite-migrate-java#796](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/796) > * `LombokValueToRecord` should rewrite method references too by [`@holgpar`](https://github.com/holgpar) in [openrewrite/rewrite-migrate-java#469](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/469) > * Update test expectations to now finish idempotent `ChangeTagAttribute` in a single cycle by [`@pdelagrave`](https://github.com/pdelagrave) in [openrewrite/rewrite-migrate-java#797](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/797) > * refactor: Unwrap else block after return or throw statement by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#798](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/798) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.13.0...v3.14.0> > > 3.13.0 > ------ > > What's Changed > -------------- > > * refactor: org.openrewrite.mavencentral by [`@Laurens-W`](https://github.com/Laurens-W) in [openrewrite/rewrite-migrate-java#778](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/778) > * Do not add explicit `Record` class import if using `var` keyword by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#781](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/781) > * Correct groupId for `jakarta.annotation:jakarta.annotation-api` upgrade by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#784](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/784) > * Keep `jakarta.annotation-api` dependency when moving to Jakarta with Spring Boot project and Jakarta annotations are used by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#782](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/782) > * Add Bouncy Castle upgrade recipe for Java < 8 by [`@pdelagrave`](https://github.com/pdelagrave) in [openrewrite/rewrite-migrate-java#790](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/790) > * Fix `LombokValToFinalVar` in loops by [`@MBoegers`](https://github.com/MBoegers) in [openrewrite/rewrite-migrate-java#768](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/768) > * Replace JavaTemplate by a `var` identifier element for UseVarForGenericsConstructors recipe by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-migrate-java#789](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/789) > * Add missing type table entries by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#792](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/792) > * Migrate Lombok's `@__` syntax to `onX_` for Java 8+ by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#794](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/794) ... (truncated) Commits * [`f65c067`](openrewrite/rewrite-migrate-java@f65c067) Restore `UpdateJakartaAnnotations2` as a deprecated placeholder * [`aa973e9`](openrewrite/rewrite-migrate-java@aa973e9) chore(ci): bump actions/checkout from 4 to 5 ([#817](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/817)) * [`a6a509e`](openrewrite/rewrite-migrate-java@a6a509e) Improve "Add explicit Common Annotations dependencies" in "Migrate to Java 11... * [`cbe5ca5`](openrewrite/rewrite-migrate-java@cbe5ca5) [Auto] SDKMAN! Java candidates as of 2025-08-11T1018 * [`180b215`](openrewrite/rewrite-migrate-java@180b215) Revert "Joda-time: Make safe migration optional ([#811](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/811))" * [`531270b`](openrewrite/rewrite-migrate-java@531270b) Joda-time: Make safe migration optional ([#811](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/811)) * [`9f029e3`](openrewrite/rewrite-migrate-java@9f029e3) Create `is` methods for boolean fields in `LombokValueToRecord` ([#813](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/813)) * [`bc6f9dc`](openrewrite/rewrite-migrate-java@bc6f9dc) Allow BouncyCastleTest to match in any order * [`eef26e4`](openrewrite/rewrite-migrate-java@eef26e4) Refactor RewriteTest to use defaults method ([#814](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/814)) * [`d9674d1`](openrewrite/rewrite-migrate-java@d9674d1) Delegate from `RemoveIllegalSemicolons` to `RemoveExtraSemicolons` * Additional commits viewable in [compare view](openrewrite/rewrite-migrate-java@v3.12.0...v3.15.0) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-migrate-java&package-manager=maven&previous-version=3.12.0&new-version=3.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

moderne-meeseeks bot added this to OpenRewrite Jul 14, 2025

github-project-automation bot moved this to In Progress in OpenRewrite Jul 14, 2025

github-actions bot reviewed Jul 14, 2025

View reviewed changes

pdelagrave force-pushed the switchexpr branch 2 times, most recently from 479d2a7 to a579d9b Compare July 14, 2025 19:04

openrewrite deleted a comment from github-actions bot Jul 14, 2025

github-actions bot reviewed Jul 14, 2025

View reviewed changes

timtebeek reviewed Jul 16, 2025

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lang/SwitchUtils.java Outdated Show resolved Hide resolved

github-actions bot reviewed Jul 16, 2025

View reviewed changes

timtebeek assigned pdelagrave Jul 17, 2025

timtebeek added recipe Recipe requested java 21+ labels Jul 17, 2025

timtebeek reviewed Jul 17, 2025

View reviewed changes

src/main/resources/META-INF/rewrite/java-version-21.yml Outdated Show resolved Hide resolved

openrewrite deleted a comment from github-actions bot Jul 17, 2025

timtebeek added 6 commits July 21, 2025 23:30

Delegate to InlineVariable to inline return

0754a4c

Use SemanticallyEqual.areEqual instead of comparing String name

a02ace0

Detect two more forms of side effects

fa9e5b5

Show the difference between colon and arrow case for null, default

ceac402

Add another test case that should not be converted

f5bb4f6

Polish

bf98d52

polish

4e3666e

pdelagrave added java 17+ and removed java 21+ labels Jul 22, 2025

pdelagrave commented Jul 22, 2025

View reviewed changes

filter out members that aren't Enum Constants when checking for switc…

c29b44c

…h exhaustiveness on an enum switch selector

pdelagrave mentioned this pull request Jul 22, 2025

Add Flag.Enum to allow identifying enum constants from other members in a JavaType.Class of Enum Kind openrewrite/rewrite#5789

Merged

3 tasks

Bhadboiab approved these changes Jul 24, 2025

View reviewed changes

pdelagrave and others added 2 commits July 25, 2025 10:24

Merge branch 'main' into switchexpr

f9637bc

Minor changes

c17a0cc

github-actions bot reviewed Jul 25, 2025

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lang/SwitchUtils.java Outdated Show resolved Hide resolved

Minimize which code paths are hit when

1464af4

github-actions bot reviewed Jul 25, 2025

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lang/SwitchUtils.java Outdated Show resolved Hide resolved

Add explicit tests for fall through handling

dccd6ec

github-actions bot reviewed Jul 25, 2025

View reviewed changes

src/main/java/org/openrewrite/java/migrate/lang/SwitchUtils.java Outdated Show resolved Hide resolved

This was referenced Jul 25, 2025

Convert switch expressions with colon to arrows #799

Closed

Convert switch cases where every case returns into a returned switch expression #800

Closed

timtebeek and others added 2 commits July 25, 2025 18:41

Update src/main/java/org/openrewrite/java/migrate/lang/SwitchUtils.java

c942001

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Add missing newline

3ca3e10

timtebeek merged commit 5906a02 into main Jul 25, 2025
2 checks passed

timtebeek deleted the switchexpr branch July 25, 2025 16:48

github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jul 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert assigning Switch statements to Switch expressions#795

Convert assigning Switch statements to Switch expressions#795
timtebeek merged 48 commits intomainfrom
switchexpr

pdelagrave commented Jul 14, 2025 •

edited by timtebeek

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Laurens-W commented Jul 15, 2025

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

timtebeek commented Jul 21, 2025

Uh oh!

pdelagrave Jul 22, 2025 •

edited

Loading

Uh oh!

pdelagrave commented Jul 22, 2025

Uh oh!

Bhadboiab left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pdelagrave commented Jul 14, 2025 • edited by timtebeek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Laurens-W commented Jul 15, 2025

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timtebeek commented Jul 21, 2025

Uh oh!

pdelagrave Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pdelagrave commented Jul 22, 2025

Uh oh!

Bhadboiab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pdelagrave commented Jul 14, 2025 •

edited by timtebeek

Loading

pdelagrave Jul 22, 2025 •

edited

Loading