Support isEnabledFor to isEnabled in Log4j 1.x to 2.x migration#277
Merged
Conversation
Closes #276 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mergify Bot
added a commit
to robfrank/linklift
that referenced
this pull request
Feb 14, 2026
…rom 3.22.0 to 3.23.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-logging-frameworks](https://github.com/openrewrite/rewrite-logging-frameworks) from 3.22.0 to 3.23.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-logging-frameworks's releases](https://github.com/openrewrite/rewrite-logging-frameworks/releases).* > 3.23.0 > ------ > > What's Changed > -------------- > > * Make declarative recipes singletons by [`@sambsnyd`](https://github.com/sambsnyd) in [openrewrite/rewrite-logging-frameworks#275](https://redirect.github.com/openrewrite/rewrite-logging-frameworks/pull/275) > * Support `isEnabledFor` to `isEnabled` in Log4j 1.x to 2.x migration by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-logging-frameworks#277](https://redirect.github.com/openrewrite/rewrite-logging-frameworks/pull/277) > > **Full Changelog**: <openrewrite/rewrite-logging-frameworks@v3.22.0...v3.23.0> Commits * [`37b84bf`](openrewrite/rewrite-logging-frameworks@37b84bf) Support `isEnabledFor` to `isEnabled` in Log4j 1.x to 2.x migration ([#277](https://redirect.github.com/openrewrite/rewrite-logging-frameworks/issues/277)) * [`86f5279`](openrewrite/rewrite-logging-frameworks@86f5279) Delete files * [`061d6b0`](openrewrite/rewrite-logging-frameworks@061d6b0) Update suppression * [`96fa8df`](openrewrite/rewrite-logging-frameworks@96fa8df) Make declarative recipes singletons ([#275](https://redirect.github.com/openrewrite/rewrite-logging-frameworks/issues/275)) * [`7b5b37d`](openrewrite/rewrite-logging-frameworks@7b5b37d) Adopt JUnit 5.14.2 where 5.13.x was pinned * [`a157f0d`](openrewrite/rewrite-logging-frameworks@a157f0d) OpenRewrite recipe best practices * See full diff in [compare view](openrewrite/rewrite-logging-frameworks@v3.22.0...v3.23.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
ChangeMethodNamerecipe step to renameCategory.isEnabledFor(Priority)toisEnabledin theLog4j1ToLog4j2recipe, placed before thePriority→Leveltype change so the method pattern matches original Log4j 1.x typesAdds test verifying
logger.isEnabledFor(Priority.INFO)is migrated tologger.isEnabled(Level.INFO)Closes Log4j rewrite could support isEnabledFor to isEnabled #276
Test plan
Log4j1ToLog4j2Testtests passisEnabledForToIsEnabledtest verifies the method rename along with type migration🤖 Generated with Claude Code