Add support for annotations to `TypeTable` by knutwannheden · Pull Request #5485 · openrewrite/rewrite

knutwannheden · 2025-05-22T20:30:04Z

This PR enhances the TypeTable infrastructure to support all three types of Java annotations (element, parameter, and
type annotations) as well as annotation attribute default values and compile-time constant values for static final fields. The TypeTable now provides complete type information including annotations, enabling more sophisticated type analysis and transformation capabilities.

Key Changes

Complete Annotation Support 📝

Added support for (runtime-invisible and -visible) annotations (CLASS and RUNTIME retention)
Added support for parameter annotations on method parameters
Added support for type annotations (TYPE_USE) on type references
Added support for annotation default values in annotation types
Added support for field compile-time constant values (e.g., 10 + 20 * 2 stored as 50)

Updated TypeTable.Reader API 🔧

Introduced TypeTable.Reader.Options with builder pattern for extensible configuration
Added read() method that accepts Options for flexible reading

Format Migration 🔄

Changed default resource from .tsv.zip to .tsv.gz for better compression
Maintained backward compatibility for reading existing type tables
Automatic handling of both compressed formats

Why This Change?

For parser use cases, having access to both annotation default values and static final field constants is essential for proper type attribution. This change ensures complete information about types is preserved in the TypeTable without requiring access to source files or full classpath resolution.

Technical Details

The implementation cleanly separates:

TSV Storage: Preserves all compile-time constant and annotation default information
Bytecode Generation: Follows JVM specifications for both annotation defaults and field ConstantValue attributes
Serialization: Handles complex nested structures with proper escaping

rewrite-java/src/test/java/DelimiterEscapingTest.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/AnnotatedClass.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/ArrayAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/BasicAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/ClassRefAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/Constants.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/EnumAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/NestedAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/StringAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/TestEnum.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/AnnotatedClass.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/ArrayAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/BasicAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/ClassRefAnnotation.java

rewrite-java/src/test/java/org/openrewrite/java/internal/parser/data/ConstantAnnotation.java