Convert pointerId to string for object lookups#7285
Merged
tschaub merged 1 commit intoopenlayers:masterfrom Sep 24, 2017
tschaub:ios-11-fix
Merged
Convert pointerId to string for object lookups#7285tschaub merged 1 commit intoopenlayers:masterfrom tschaub:ios-11-fix
tschaub merged 1 commit intoopenlayers:masterfrom
tschaub:ios-11-fix
Conversation
|
You guys are a godsend if this works! |
Merged
mdastous-bentley
pushed a commit
to BentleySystems/openlayers
that referenced
this pull request
May 27, 2020
Convert pointerId to string for object lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using the expression
property in objectwherepropertyis a number, and apparently Safari on IOS11 doesn't like that when the number is negative. Althoughevent.pointerIdis a number it is legitimate to convert to a string when we use it as an object property name. So even if this is a Safari bug, I think it is a legitimate change to make.Thanks @ogo-adp for debugging and identifying the fix.
Fixes #7202.