8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError by mlchung · Pull Request #96 · openjdk/jdk

mlchung · 2020-09-09T19:38:38Z

jlink --generate-jli-classes plugin should retain the original holder classes if the default_jli_trace.txt
file does not exist.

Before JDK-8252725, JavaLangInvokeAccess::generateXXXHolderClassesBytes methods are invoked
unconditionally and therefore the holder classes are "regenerated" when default_jli_trace.txt
does not exist. JDK-8252725 does not handle this case properly and results in an image missing
the holder classes when the specified trace file does not exist.

The fix is very simple. Retains the original holder classes when the file does not exist.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError: DirectMethodHandle$Holder ⚠️ Title mismatch between PR and JBS.

Reviewers

Yumin Qi (@yminqi - Reviewer)
Athijegannathan Sundararajan (@sundararajana - Reviewer)
Alan Bateman (@AlanBateman - Reviewer)
Claes Redestad (@cl4es - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/96/head:pull/96
$ git checkout pull/96

…or: DirectMethodHandle

bridgekeeper · 2020-09-09T19:40:05Z

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-09T19:41:00Z

@mlchung The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

mlbridge · 2020-09-09T19:43:58Z

Webrevs

00: Full (0129d2f)

yminqi · 2020-09-09T21:56:30Z

Looks good!

openjdk · 2020-09-09T22:01:14Z

@mlchung This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError

Reviewed-by: minqi, sundar, alanb, redestad

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 9 commits pushed to the master branch:

418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
f933961: 8252980: comment only changes extracted from JDK-8247281

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 418e4a259c8ba02c5d7a3cc0124f9e8980dc9c8e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

sundararajana

Looks good

mlchung · 2020-09-10T16:04:10Z

/integrate

openjdk · 2020-09-10T16:05:07Z

@mlchung Since your change was applied there have been 9 commits pushed to the master branch:

418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
41d29b7: 8252774: remove jdk.test.lib.FileInstaller action from graalunit tests
5b30a83: 8252778: remove jdk.test.lib.FileInstaller action from compiler/c2/stemmer test
8db3335: 8247928: Refactor G1ConcurrentMarkThread for mark abort
7ccf435: 8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…
d236cf4: 8252995: Non-PCH builds broken by JDK-8250961
6a00534: 8250961: Move Universe::update_heap_info_at_gc to CollectedHeap
f78f780: 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy
f933961: 8252980: comment only changes extracted from JDK-8247281

Your commit was automatically rebased without conflicts.

Pushed as commit 44a74da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Restore looks like this now: ``` 0x0000000106e4dfcc: movk x9, #0x5e4, lsl openjdk#16 0x0000000106e4dfd0: movk x9, #0x1, lsl openjdk#32 0x0000000106e4dfd4: blr x9 0x0000000106e4dfd8: ldp x2, x3, [sp, openjdk#16] 0x0000000106e4dfdc: ldp x4, x5, [sp, openjdk#32] 0x0000000106e4dfe0: ldp x6, x7, [sp, openjdk#48] 0x0000000106e4dfe4: ldp x8, x9, [sp, openjdk#64] 0x0000000106e4dfe8: ldp x10, x11, [sp, openjdk#80] 0x0000000106e4dfec: ldp x12, x13, [sp, openjdk#96] 0x0000000106e4dff0: ldp x14, x15, [sp, openjdk#112] 0x0000000106e4dff4: ldp x16, x17, [sp, openjdk#128] 0x0000000106e4dff8: ldp x0, x1, [sp], openjdk#144 0x0000000106e4dffc: ldp xzr, x19, [sp], openjdk#16 0x0000000106e4e000: ldp x22, x23, [sp, openjdk#16] 0x0000000106e4e004: ldp x24, x25, [sp, openjdk#32] 0x0000000106e4e008: ldp x26, x27, [sp, openjdk#48] 0x0000000106e4e00c: ldp x28, x29, [sp, openjdk#64] 0x0000000106e4e010: ldp x30, xzr, [sp, openjdk#80] 0x0000000106e4e014: ldp x20, x21, [sp], openjdk#96 0x0000000106e4e018: ldur x12, [x29, #-24] 0x0000000106e4e01c: ldr x22, [x12, openjdk#16] 0x0000000106e4e020: add x22, x22, #0x30 0x0000000106e4e024: ldr x8, [x28, openjdk#8] ```

…tation classes #96 ActivationGroupIDSerializer modified to use serialization to access serial fields, illegal reflective access has been removed.

…tation classes #96 move ActivationGroupID from internal class to package private class.

Some vector operations do not have inputs and essentially initialize vectors with a constant value. These operations can be marked for spilling and subsequently rematerialized at every use. The result of the transformation might look as follows: movi v16.2d, #0x0 str q16, [x16, openjdk#64] movi v16.2d, #0x0 str q16, [x16, openjdk#32] movi v16.2d, #0x0 str q16, [x16, openjdk#16] movi v16.2d, #0x0 str q16, [x16] movi v16.2d, #0x0 str q16, [x16, openjdk#48] movi v16.2d, #0x0 str q16, [x16, openjdk#112] movi v16.2d, #0x0 str q16, [x16, openjdk#80] movi v16.2d, #0x0 str q16, [x16, openjdk#96] Introduce deduplication of these rematerialized vector constant initializations reducing the above sequence to: movi v16.2d, #0x0 str q16, [x16, openjdk#64] str q16, [x16, openjdk#32] str q16, [x16, openjdk#16] str q16, [x16] str q16, [x16, openjdk#48] str q16, [x16, openjdk#112] str q16, [x16, openjdk#80] str q16, [x16, openjdk#96]

8252919: JDK built with --enable-cds=no fails with NoClassDefFoundErr…

0129d2f

…or: DirectMethodHandle

openjdk Bot added the rfr Pull request is ready for review label Sep 9, 2020

openjdk Bot added the core-libs core-libs-dev@openjdk.org label Sep 9, 2020

yminqi approved these changes Sep 9, 2020

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Sep 9, 2020

sundararajana approved these changes Sep 10, 2020

View reviewed changes

AlanBateman approved these changes Sep 10, 2020

View reviewed changes

cl4es approved these changes Sep 10, 2020

View reviewed changes

openjdk Bot closed this Sep 10, 2020

openjdk Bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 10, 2020

mlchung deleted the jlink-plugin branch February 16, 2021 22:30

pfirmstone referenced this pull request in pfirmstone/DirtyChai Nov 18, 2024

Remove deprecated classes that use reflection to access Java implemen…

376cde3

…tation classes #96 move ActivationGroupID from internal class to package private class.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError#96

8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError#96
mlchung wants to merge 1 commit intoopenjdk:masterfrom
mlchung:jlink-plugin

mlchung commented Sep 9, 2020 •

edited by openjdk Bot

Loading

Uh oh!

bridgekeeper Bot commented Sep 9, 2020

Uh oh!

openjdk Bot commented Sep 9, 2020

Uh oh!

mlbridge Bot commented Sep 9, 2020

Uh oh!

yminqi commented Sep 9, 2020

Uh oh!

openjdk Bot commented Sep 9, 2020 •

edited

Loading

Uh oh!

sundararajana left a comment

Uh oh!

mlchung commented Sep 10, 2020

Uh oh!

openjdk Bot commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Conversation

mlchung commented Sep 9, 2020 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Download

Uh oh!

bridgekeeper Bot commented Sep 9, 2020

Uh oh!

openjdk Bot commented Sep 9, 2020

Uh oh!

mlbridge Bot commented Sep 9, 2020

Webrevs

Uh oh!

yminqi commented Sep 9, 2020

Uh oh!

openjdk Bot commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sundararajana left a comment

Choose a reason for hiding this comment

Uh oh!

mlchung commented Sep 10, 2020

Uh oh!

openjdk Bot commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

mlchung commented Sep 9, 2020 •

edited by openjdk Bot

Loading

openjdk Bot commented Sep 9, 2020 •

edited

Loading