Dart: Use case of identifier to guess Call vs New#555
Merged
maciejpirog merged 2 commits intomainfrom Jan 23, 2026
Merged
Conversation
dimitris-m
reviewed
Jan 22, 2026
Comment on lines
+1929
to
+1935
| (* Just by looking at the syntax, we cannot know when a(...) is *) | ||
| (* a function call or a "new" expression, because the "new" keyword *) | ||
| (* is optional. However, there is almost universal convention in *) | ||
| (* Dart that types begin with an uppercase, while everything else *) | ||
| (* with a lowercase character. We use this convention as a heuristic: *) | ||
| (* if an identifier starts with an uppercase char, we convert it to *) | ||
| (* G.New; othwerwise, it is a call. *) |
Collaborator
There was a problem hiding this comment.
NIT: This comment style (independent lines) is a little weird imo. Hard to edit comments.
Collaborator
There was a problem hiding this comment.
Also a bit inconsistent with the rest of the codebase.
dimitris-m
approved these changes
Jan 22, 2026
Collaborator
dimitris-m
left a comment
There was a problem hiding this comment.
LGTM but I would change this comment style as noted in my comment...
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 15, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [opengrep/opengrep](https://github.com/opengrep/opengrep) | minor | `v1.15.1` → `v1.16.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>opengrep/opengrep (opengrep/opengrep)</summary> ### [`v1.16.0`](https://github.com/opengrep/opengrep/releases/tag/v1.16.0): Opengrep 1.16.0 [Compare Source](opengrep/opengrep@v1.15.1...v1.16.0) #### Improvements - Dart: Add typed metavariabless by [@​maciejpirog](https://github.com/maciejpirog) in [#​551](opengrep/opengrep#551) - Dart: Use case of identifier to guess call vs new by [@​maciejpirog](https://github.com/maciejpirog) in [#​555](opengrep/opengrep#555) - Go: Enable goroutines in taint tracking by [@​maciejpirog](https://github.com/maciejpirog) in [#​559](opengrep/opengrep#559) - Add taint propagation via "for" comprehensions by [@​maciejpirog](https://github.com/maciejpirog) in [#​564](opengrep/opengrep#564) #### Bug Fixes - Rust: Missing Rust type alias translation by [@​smith-xyz](https://github.com/smith-xyz) in [#​549](opengrep/opengrep#549) - Fix: Ensure that linux binaries have 8mb stack size (musl) by [@​dimitris-m](https://github.com/dimitris-m) in [#​563](opengrep/opengrep#563) - Fixed a perf regression by removing system calls and improving the reachability graph and the callee lookup by [@​corneliuhoffman](https://github.com/corneliuhoffman) in [#​556](opengrep/opengrep#556) - Fixed intrafile bug introduced by a superfluous fallback by [@​corneliuhoffman](https://github.com/corneliuhoffman) in [#​567](opengrep/opengrep#567) - Ruby: Always translate `or` and `and` to expression by [@​maciejpirog](https://github.com/maciejpirog) in [#​562](opengrep/opengrep#562) - Bash: Allow redirects before command arguments by [@​maciejpirog](https://github.com/maciejpirog) in [#​548](opengrep/opengrep#548) #### Internal Improvements - Add `show dump-intrafile-graph` and `show dump-taint-signatures` commands by [@​corneliuhoffman](https://github.com/corneliuhoffman) in [#​552](opengrep/opengrep#552) - Improve tainting code by [@​maciejpirog](https://github.com/maciejpirog) in [#​546](opengrep/opengrep#546) - Graph refactoring by [@​corneliuhoffman](https://github.com/corneliuhoffman) in [#​553](opengrep/opengrep#553) #### New Contributors - [@​smith-xyz](https://github.com/smith-xyz) made their first contribution in [#​549](opengrep/opengrep#549) **Full Changelog**: <opengrep/opengrep@v1.15.1...v1.16.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Ni4yIiwidXBkYXRlZEluVmVyIjoiNDIuOTYuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Dart, the
newkeyword is optional and the convention is to omit it. So, in theory, there is no difference between the syntax of a function call and a creation of a new object via a call to constructor (it is determined by the type checker in the compiler, and so we were translating both cases toCall). However, a strictly followed convention in Dart is that names of types begin with uppercase characters, while names of functions begin with with lowercase characters. We use that as a heuristic, translating toCallorNewbased on the case of the identifier.This way, for the rule:
We have: