C#: Collection expressions vs attributes with targets (parser fix)#539
Merged
maciejpirog merged 2 commits intomainfrom Jan 14, 2026
Merged
Conversation
dimitris-m
reviewed
Jan 14, 2026
dimitris-m
reviewed
Jan 14, 2026
Collaborator
dimitris-m
left a comment
There was a problem hiding this comment.
Do we really need anything except the test and the submodule update?
Related to comments on opengrep/semgrep-c-sharp#4.
Contributor
Author
The generated CST changed, so we have to update Parse_csharp_tree_sitter.ml as well |
dimitris-m
reviewed
Jan 14, 2026
| { | ||
| void foo() | ||
| { | ||
| x = [type]; |
Collaborator
There was a problem hiding this comment.
aren't words like type reserved keywords?
Contributor
Author
There was a problem hiding this comment.
nope, type has no special meaning in C# except as a target in an attribute, as in the following:
[type: Obsolete("Use NewClass instead")]
public class OldClass { }
dimitris-m
approved these changes
Jan 14, 2026
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 17, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [opengrep/opengrep](https://github.com/opengrep/opengrep) | minor | `v1.14.1` → `v1.15.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>opengrep/opengrep (opengrep/opengrep)</summary> ### [`v1.15.1`](https://github.com/opengrep/opengrep/releases/tag/v1.15.1): Opengrep 1.15.1 [Compare Source](opengrep/opengrep@v1.15.0...v1.15.1) #### Bug fixes - Clojure translation improvements by [@​dimitris-m](https://github.com/dimitris-m) in [#​534](opengrep/opengrep#534) **Full Changelog**: <opengrep/opengrep@v1.15.0...v1.15.1> ### [`v1.15.0`](https://github.com/opengrep/opengrep/releases/tag/v1.15.0): Opengrep 1.15.0 [Compare Source](opengrep/opengrep@v1.14.1...v1.15.0) #### What's Changed - Clojure translation part III by [@​dimitris-m](https://github.com/dimitris-m) in [#​527](opengrep/opengrep#527) - Php modernisation by [@​corneliuhoffman](https://github.com/corneliuhoffman) in [#​529](opengrep/opengrep#529) - Intrafile tainting with variadic functions by [@​maciejpirog](https://github.com/maciejpirog) in [#​538](opengrep/opengrep#538) - C#: The `field` implicit parameter can be skipped in a pattern by [@​maciejpirog](https://github.com/maciejpirog) in [#​525](opengrep/opengrep#525) - C#: Add conditional array access (`?[...]`) to l-values by [@​maciejpirog](https://github.com/maciejpirog) in [#​535](opengrep/opengrep#535) - C#: Collection expressions vs attributes with targets (parser fix) by [@​maciejpirog](https://github.com/maciejpirog) in [#​539](opengrep/opengrep#539) - Add `noopengrep` to the default nosem patterns by [@​dimitris-m](https://github.com/dimitris-m) in [#​533](opengrep/opengrep#533) **Full Changelog**: <opengrep/opengrep@v1.14.1...v1.15.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44MS4yIiwidXBkYXRlZEluVmVyIjoiNDIuODIuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser confused collection expression that started with an identifier similar to an attribute target, e.g.,
[type, ...]etc with attributes with targets[type: ...].