Skip to content

avro: extend avro-c++ to native and nativesdk#812

Closed
RuiMarioCosta wants to merge 1 commit intoopenembedded:masterfrom
RuiMarioCosta:avro-c++-extend
Closed

avro: extend avro-c++ to native and nativesdk#812
RuiMarioCosta wants to merge 1 commit intoopenembedded:masterfrom
RuiMarioCosta:avro-c++-extend

Conversation

@RuiMarioCosta
Copy link
Copy Markdown

@RuiMarioCosta RuiMarioCosta commented Apr 15, 2024 •
edited
Loading

  • fix HOMEPAGE for both avro recipes
  • fix cmake install paths in patch

@shr-project
Copy link
Copy Markdown
Contributor

shr-project commented Apr 15, 2024

Please fix the issues reported in #807 first.

@RuiMarioCosta RuiMarioCosta force-pushed the avro-c++-extend branch 2 times, most recently from b781175 to 0f1a3fb Compare April 15, 2024 15:43
@RuiMarioCosta
Copy link
Copy Markdown
Author

RuiMarioCosta commented Apr 15, 2024 •
edited
Loading

@shr-project I fixed the multilib build but I still get a warning saying

WARNING: avro-c++-1.11.3-r0 do_package_qa: QA Issue: avro-c++-dbg: found library in wrong location: /usr/lib/.debug/libavrocpp.so.1.11.3-lib64
avro-c++-dev: found library in wrong location: /usr/lib/libavrocpp.so.1.11.3-lib64 [libdir]

I get what the issue is but by looking at some of the other recipes I don't understand what could I do different in the recipe. Do you know what could solve this?

@shr-project
Copy link
Copy Markdown
Contributor

shr-project commented Apr 16, 2024

@shr-project I fixed the multilib build but I still get a warning saying

WARNING: avro-c++-1.11.3-r0 do_package_qa: QA Issue: avro-c++-dbg: found library in wrong location: /usr/lib/.debug/libavrocpp.so.1.11.3-lib64
avro-c++-dev: found library in wrong location: /usr/lib/libavrocpp.so.1.11.3-lib64 [libdir]

I get what the issue is but by looking at some of the other recipes I don't understand what could I do different in the recipe. Do you know what could solve this?

"-lib64" suffix at the end doesn't look like correct fix, did you use CMAKE_INSTALL_LIBDIR as DESTINATION?

There are many examples how to fix it in https://git.openembedded.org/meta-openembedded/log/?h=scarthgap&qt=grep&q=libdir

@RuiMarioCosta
Copy link
Copy Markdown
Author

RuiMarioCosta commented Apr 16, 2024

@shr-project I fixed the multilib build but I still get a warning saying

WARNING: avro-c++-1.11.3-r0 do_package_qa: QA Issue: avro-c++-dbg: found library in wrong location: /usr/lib/.debug/libavrocpp.so.1.11.3-lib64
avro-c++-dev: found library in wrong location: /usr/lib/libavrocpp.so.1.11.3-lib64 [libdir]

I get what the issue is but by looking at some of the other recipes I don't understand what could I do different in the recipe. Do you know what could solve this?

"-lib64" suffix at the end doesn't look like correct fix, did you use CMAKE_INSTALL_LIBDIR as DESTINATION?

There are many examples how to fix it in https://git.openembedded.org/meta-openembedded/log/?h=scarthgap&qt=grep&q=libdir

@shr-project you were right, I had the cmake install paths hardcoded in the patch file. It should be fixed now. Thanks

shr-project
shr-project requested changes Apr 16, 2024
View reviewed changes
avro: extend avro-c++ to native and nativesdk
f5b9622 
- fix HOMEPAGE for both avro recipes
- fix cmake install paths in patch
shr-project
shr-project approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shr-project shr-project left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, builds OK now.

@RuiMarioCosta
Copy link
Copy Markdown
Author

RuiMarioCosta commented Apr 18, 2024

Hello @shr-project can you give me an estimate of when this will be merged?

@RuiMarioCosta
Copy link
Copy Markdown
Author

RuiMarioCosta commented Apr 18, 2024

Hello @shr-project can you give me an estimate of when this will be merged?

Nevermind, just checked in master and the commit is there. I was waiting for this PR to be closed like in the other case. In that case can this PR be closed?

@kraj
Copy link
Copy Markdown
Contributor

kraj commented Apr 18, 2024

Merged c4107ba

@kraj kraj closed this Apr 18, 2024
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 15, 2025
@MarkusVolk @kraj
wireplumber: update 0.5.10 -> 0.5.11
6bc66dc 
WirePlumber 0.5.11
~~~~~~~~~~~~~~~~~~
Additions & Enhancements:

  - Added modem manager module for tracking voice call status and voice call
    device profile selection hooks to improve phone call audio routing on
    mobile devices (!722, !729, openembedded#819)
  - Added MPRIS media player pause functionality that automatically pauses
    media playback when the audio target (e.g. headphones) is removed (!699, openembedded#764)
  - Added support for human-readable names and localization of settings in
    ``wireplumber.conf`` with ``wpctl`` displaying localized setting descriptions (!712)
  - Improved default node selection logic to use both session and route
    priorities when nodes have equal session priorities (!720)
  - Increased USB device priority in the ALSA monitor (!719)

Fixes:

  - Fixed multiple Lua runtime issues including type confusion bugs, stack
    overflow prevention, and SPA POD array/choice builders (!723, !728)
  - Fixed proxy object lifecycle management by properly clearing the
    OWNED_BY_PROXY flag when proxies are destroyed to prevent dangling
    pointers (!732)
  - Fixed state-routes handling to prevent saving unavailable routes and
    eliminate race conditions during profile switching (!730, openembedded#762)
  - Fixed some memory leaks in the script tester and the settings iterator (!727, !726)
  - Fixed a potential crash caused by module-loopback destroying itself when the
    pipewire connection is closed (openembedded#812)
  - Fixed profile saving behavior in ``wpctl set-profile`` command (openembedded#808)
  - Fixed GObject introspection closure annotation

Signed-off-by: Markus Volk <f_l_k@t-online.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 15, 2025
@MarkusVolk @kraj
wireplumber: update 0.5.10 -> 0.5.11
96f7952 
WirePlumber 0.5.11
~~~~~~~~~~~~~~~~~~
Additions & Enhancements:

  - Added modem manager module for tracking voice call status and voice call
    device profile selection hooks to improve phone call audio routing on
    mobile devices (!722, !729, openembedded#819)
  - Added MPRIS media player pause functionality that automatically pauses
    media playback when the audio target (e.g. headphones) is removed (!699, openembedded#764)
  - Added support for human-readable names and localization of settings in
    ``wireplumber.conf`` with ``wpctl`` displaying localized setting descriptions (!712)
  - Improved default node selection logic to use both session and route
    priorities when nodes have equal session priorities (!720)
  - Increased USB device priority in the ALSA monitor (!719)

Fixes:

  - Fixed multiple Lua runtime issues including type confusion bugs, stack
    overflow prevention, and SPA POD array/choice builders (!723, !728)
  - Fixed proxy object lifecycle management by properly clearing the
    OWNED_BY_PROXY flag when proxies are destroyed to prevent dangling
    pointers (!732)
  - Fixed state-routes handling to prevent saving unavailable routes and
    eliminate race conditions during profile switching (!730, openembedded#762)
  - Fixed some memory leaks in the script tester and the settings iterator (!727, !726)
  - Fixed a potential crash caused by module-loopback destroying itself when the
    pipewire connection is closed (openembedded#812)
  - Fixed profile saving behavior in ``wpctl set-profile`` command (openembedded#808)
  - Fixed GObject introspection closure annotation

Signed-off-by: Markus Volk <f_l_k@t-online.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shr-project shr-project shr-project approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RuiMarioCosta @shr-project @kraj