[meta-oe] Introduce recipe for sdbus-c++ library and its tools by sangelovic · Pull Request #137 · openembedded/meta-openembedded

sangelovic · 2019-06-12T09:57:34Z

sdbus-c++ is a high-level C++ D-Bus library written on top of systemd D-Bus implementation originally as a modern, robust replacement for dbus-c++.

There are two main recipes and one helper recipe:

Recipe for sdbus-c++ itself. It detects whether systemd feature is turned on. If so, it depends on systemd and links against libsystemd. Otherwise it builds libsystemd as part of building sdbus-c++. (Building of libsystemd for sdbus-c++ is performed by helper sdbus-c++-libsystemd recipe.) The recipe also supports ptest.
Recipe for sdbus-c++ native tools, namely sdbus-c++ code generator to generate C++ adaptor and proxy binding classes.

The recipes have been tested on yocto master.

meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools-native_0.7.1.bb

meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.7.1.bb

sangelovic · 2019-07-09T16:08:18Z

Hello, thanks for comments, and sorry for coming back to this after longer time. I was busy, but now is the time. I addressed your comments and at the same time bumped library version from v0.7.1 to v0.7.2 which contains an important fix. So the recipes are renamed. Please re-review... Thanks a lot!

kraj · 2019-07-09T16:33:43Z

Hello, thanks for comments, and sorry for coming back to this after longer time. I was busy, but now is the time. I addressed your comments and at the same time bumped library version from v0.7.1 to v0.7.2 which contains an important fix. So the recipes are renamed. Please re-review... Thanks a lot!

thanks for reworking on it. Can you squash all the commits into a single commit and upload again please

sangelovic · 2019-07-09T18:54:29Z

thanks for reworking on it. Can you squash all the commits into a single commit and upload again please

Done.

kraj · 2019-07-09T20:15:56Z

meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.7.2.bb

+inherit cmake pkgconfig systemd ptest python3native
+
+DEPENDS += "expat ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', 'meson-native ninja-native git-native gperf-native gettext-native util-linux glibc libcap', d)}"
+RDEPENDS_${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'libsystemd', 'glibc libcap', d)}"


I think hardcoding dependency on 'glibc' is not right. Did you mean something else here ?

In this case sdbus-c++ build-depends and runtime-depends on librt library, which is AFAIK part of glibc. Do you have different suggestion in this regard?

Librt is provided by c library and is not Glibc specific secondly dependency on Glibc are automatically added and are not required to be explicitly added

So can I just remove glibc from DEPENDS and RDEPENDS?

librt is provided by c library, but isn't glibc an implementation of c library for Linuxes?

glibc is one of many, there is musl, there uclibc and maybe more. in OE we actively support musl and glibc, so hardcoding a libc dependency is not preferred unless its absolutely required then also we use COMPATIBLE_HOST variable to control the recipes for targets

OK, glibc was removed.

kraj · 2019-07-09T20:16:35Z

meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.7.2.bb

+
+inherit cmake pkgconfig systemd ptest python3native
+
+DEPENDS += "expat ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', 'meson-native ninja-native git-native gperf-native gettext-native util-linux glibc libcap', d)}"


I think hardcoding dependency on 'glibc' is not right. Did you mean something else here ?
and I dont understand why these dependencies are conditional on systemd. They should be added
in general.

Things are conditional because of flexibility. sdbus-c++ has two modes of building. One is when entire systemd ecosystem is available in the system. Then libsystemd shared library, the library with lower level D-Bus C implementation which sdbus-c++ depends on, is available, and will be used. But sdbus-c++ provides flexibility to be used as a self-contained lib on non-systemd systems (where there is no libsystemd shared library) as well. In that case, sdbus-c++ build builds just the small needed part of entire systemd and incorporates it as part of sdbus-c++ lib, making sdbus-c++ independent of systemd. Hence this conditional logic in the recipe which checks whether systemd feature is on or off. The user of yocto doesn't care, they build sdbus-c++ into their OS and it works perfectly whether or not systemd ecosystem is present.

Regarding glibc, see previous comment.

When sdbus-c++ needs to build that sd-bus part of systemd, which is in libsystemd, it needs all those additional deps, like meson-native ninja-native libpcap etc.

Okay and to be clear these dependencies are not needed when building without systemd

Okay and to be clear these dependencies are not needed when building without systemd

Yes, when building sdbus-c++ in a system where systemd feature is turned on (systemd is present), these dependencies are not selected, instead simply systemd dependency is selected.

kraj · 2019-07-09T20:18:12Z

meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.7.2.bb

+SECTION = "libs"
+
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://${WORKDIR}/sdbus-cpp-${PV}/COPYING;md5=1803fa9c2c3ce8cb06b4861d75310742"


You dont need ${WORKDIR}/sdbus-cpp-${PV}/ here

kraj · 2019-07-09T20:19:07Z

meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools-native_0.7.2.bb

+inherit cmake native
+
+DEPENDS += "expat"
+RDEPENDS_${PN} = "expat"


we only need this rdep it if tools are doing dlopen on libexpat, otherwise, shlib tool will automatically pick it up

shr-project · 2019-07-10T15:55:56Z

meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.7.2.bb

+EXTRA_OECMAKE = "-DBUILD_CODE_GEN=ON \
+                 -DBUILD_DOC=ON \
+                 -DBUILD_DOXYGEN_DOC=OFF \
+                 ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '-DBUILD_LIBSYSTEMD=OFF', '-DBUILD_LIBSYSTEMD=ON', d)} \


Use PACKAGECONFIG for this and move all extra build-time and runtime dependencies for libsystemd to PACKAGECONFIG.

Done. Can you please review whether I've done that properly?

shr-project · 2019-07-10T15:56:34Z

meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.7.2.bb

+
+# Allow CMake to use git on the host machine
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "BOTH"
+# Ninja is the default CMake generator in Yocto now, so let's set Unix Makefiles explicitly


Please say why, are the generated Makefiles incompatible with Ninja?

When building the recipe with Ninja, I get: ninja: error: 'libsystemd-v242/src/LibsystemdBuildProject-build/libsystemd.a', needed by 'libsdbus-c++.so.0.7.2', missing and no known rule to make it.

sdbus-c++ uses ExternalProject feature of CMake and builds libsystemd using that. This is where it doesn't work with Ninja out of the box.

sangelovic · 2019-07-20T21:49:57Z

I addressed all your comments, please check... Is it OK now?

kraj · 2019-07-22T07:56:02Z

please squash all into single commit and push again

sangelovic · 2019-07-22T09:56:56Z

please squash all into single commit and push again

Done.

kraj · 2019-07-23T14:28:00Z

here is new error

https://errors.yoctoproject.org/Errors/Details/253801/

sangelovic · 2019-07-23T14:45:24Z

What do logs at TOPDIR/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-stamp/LibsystemdBuildProject-configure-*.log say?

…

On Tue, Jul 23, 2019, 16:28 Khem Raj ***@***.***> wrote: here is new error https://errors.yoctoproject.org/Errors/Details/253801/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#137?email_source=notifications&email_token=ABM3OUWZJIDRMDIBGNH6EUDQA4IPJA5CNFSM4HXHJPSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TJPWY#issuecomment-514234331>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABM3OUTKTZOMQPOLOVC6NR3QA4IPJANCNFSM4HXHJPSA> .

kraj · 2019-07-23T15:53:40Z

CMake Error at /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-stamp/LibsystemdBuildProject-configure--impl.cmake:19 (message):
  Command failed (1):

   '/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native/usr/bin/meson' '--buildtype=plain' '-Dstatic-libsystemd=pic' '/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject' '/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build'

kraj · 2019-07-23T15:55:10Z

The Meson build system
Version: 0.50.1
Source dir: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject
Build dir: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build
Build type: cross build
Project name: systemd
Project version: 242
Appending CFLAGS from environment: ' -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot=                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native=   -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong  -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security  --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot'
Appending LDFLAGS from environment: '-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now'
Appending CFLAGS from environment: ' -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot=                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native=   -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong  -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security  --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot'
Appending LDFLAGS from environment: '-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now'

meson.build:3:0: ERROR: Could not invoke sanity test executable: [Errno 8] Exec format error: '/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-private/sanitycheckc.exe'.

A full log can be found at /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-logs/meson-log.txt

sangelovic · 2019-07-23T16:40:35Z

Thanks a lot. Would you please also paste the content of /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-logs/meson-log.txt here? That should be enough for me to start investigating the issue.

…

On Tue, Jul 23, 2019, 17:55 Khem Raj ***@***.***> wrote: ` The Meson build system Version: 0.50.1 Source dir: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject Build dir: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build Build type: cross build Project name: systemd Project version: 242 Appending CFLAGS from environment: ' -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0 -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0 -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot= -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native= -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot' Appending LDFLAGS from environment: '-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now' Appending CFLAGS from environment: ' -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0 -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0 -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot= -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native= -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot' Appending LDFLAGS from environment: '-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now' meson.build:3:0: ERROR: Could not invoke sanity test executable: [Errno 8] Exec format error: '/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-private/sanitycheckc.exe'. A full log can be found at /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-logs/meson-log.txt ` — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#137?email_source=notifications&email_token=ABM3OUSI3FM7JIYHVMNC5GLQA4SWDA5CNFSM4HXHJPSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TSWEI#issuecomment-514272017>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABM3OURZYHXL2UPTPOT35NLQA4SWDANCNFSM4HXHJPSA> .

kraj · 2019-07-23T16:42:26Z

Build started at 2019-07-23T06:32:58.982388
Main binary: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native/usr/bin/nativepython3
Python system: Linux
The Meson build system
Version: 0.50.1
Source dir: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject
Build dir: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build
Build type: cross build
Project name: systemd
Project version: 242
Appending CFLAGS from environment: ' -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot=                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native=   -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong  -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security  --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot'
Appending LDFLAGS from environment: '-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now'
Appending CFLAGS from environment: ' -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0=/usr/src/debug/sdbus-c++/0.7.2-r0                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot=                      -fdebug-prefix-map=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot-native=   -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong  -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security  --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot'
Appending LDFLAGS from environment: '-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now'
Sanity testing C compiler: aarch64-yoe-linux-musl-clang -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot
Is cross compiler: False.
Sanity check compiler command line: aarch64-yoe-linux-musl-clang -mcpu=cortex-a53+crc --rtlib=compiler-rt --stdlib=libc++ -mlittle-endian -Wno-error=unused-command-line-argument -Qunused-arguments -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/recipe-sysroot /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-private/sanitycheckc.c -o /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-private/sanitycheckc.exe
Sanity check compile stdout:

-----
Sanity check compile stderr:

-----
Running test binary command: /mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-private/sanitycheckc.exe

meson.build:3:0: ERROR: Could not invoke sanity test executable: [Errno 8] Exec format error: '/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/sdbus-c++/0.7.2-r0/build/libsystemd-v242/src/LibsystemdBuildProject-build/meson-private/sanitycheckc.exe'.

kraj · 2019-08-14T05:02:07Z

do you plan to submit a new version with fixes

sangelovic · 2019-08-14T06:39:51Z

Yes, I do. (Just didn't have much time for it at this recent summer time...)

…

On Wed, Aug 14, 2019, 07:02 Khem Raj ***@***.***> wrote: do you plan to submit a new version with fixes — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#137?email_source=notifications&email_token=ABM3OURYITOA2NSOEZAREDLQEOGVHA5CNFSM4HXHJPSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HWHKI#issuecomment-521102249>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABM3OUVN4JOGD7PE76QOLB3QEOGVHANCNFSM4HXHJPSA> .

sangelovic · 2019-10-13T16:44:33Z

Hi Khem, I finally got time to address sdbus-c++ recipe review comments and ARM build error. I have significantly refactored the recipe. Now systemd library is built by a specific auxiliary recipe of its own - sdbus-c++-libsystemd (version of libsystemd is 242, because that's current stable version for sdbus-c++, but I'll check 243 very soon). sdbus-c++ will just depend on it, in case systemd feature is off. I've also addressed review comments of Stefan Herbrechtsmeier.

Hopefully we are getting to final accepted state of sdbus-c++ recipes.

Please could you re-review?

kraj · 2019-10-17T03:26:17Z

https://errors.yoctoproject.org/Errors/Details/273663/

sangelovic · 2019-10-18T18:47:56Z

Strange. I need to reproduce this locally, I have no experience with raspberry target. How can I reproduce this? What settings shall I apply in my local yocto build? Thank you...

…

On Thu, Oct 17, 2019, 05:26 Khem Raj ***@***.***> wrote: https://errors.yoctoproject.org/Errors/Details/273663/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#137?email_source=notifications&email_token=ABM3OUX3YEBD3PGZZXDO2PTQO7LN3A5CNFSM4HXHJPSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBOT5ZQ#issuecomment-542981862>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABM3OUQT64GYP7H46U2PHELQO7LN3ANCNFSM4HXHJPSA> .

sangelovic · 2019-10-18T18:49:55Z

I tested ARM and x86 platforms, these work fine... Missing printf.h is a strange problem. Given that an official release of systemd is being built...

…

On Thu, Oct 17, 2019, 05:26 Khem Raj ***@***.***> wrote: https://errors.yoctoproject.org/Errors/Details/273663/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#137?email_source=notifications&email_token=ABM3OUX3YEBD3PGZZXDO2PTQO7LN3A5CNFSM4HXHJPSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBOT5ZQ#issuecomment-542981862>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABM3OUQT64GYP7H46U2PHELQO7LN3ANCNFSM4HXHJPSA> .

kraj · 2019-10-22T17:05:07Z

this is mostly because its using TCLIBC = "musl" so you might want to set that in local.conf

kraj

Please test with TCLIBC = "musl"

sangelovic · 2019-11-10T16:55:22Z

I've provided patches for MUSL. Please re-review...

kraj · 2019-11-10T17:01:02Z

@sangelovic Please squash all the patches into a single patch and send the pull

sangelovic · 2019-11-10T17:21:29Z

@kraj Done.

kraj · 2019-11-10T18:53:00Z

I have cherry-picked it for master-next, in future add your sign-offs to commits, and commit msg guidelines are here [1]

[1] https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

kraj · 2019-11-10T18:54:07Z

fails to build with clang/libc++/musl

http://errors.yoctoproject.org/Errors/Details/275653/

kraj

I think this needs a bit more love, almost there :)

kraj · 2019-11-12T01:47:35Z

Fetch errors

http://errors.yoctoproject.org/Errors/Details/275690/

sdbus-c++ is a high-level, expressive, easy-to-use C++ D-Bus client library written on top of systemd D-Bus client C library. Signed-off-by: Stanislav Angelovic <angelovic.s@gmail.com>

sangelovic · 2020-01-05T22:20:20Z

Hi @kraj . Thanks for having patience with me :) I fixed the clang issues. I've also updated the commit message, I hope it's along the guidelines now. Please could you re-test? I hope this could finally make it...

sangelovic · 2020-01-05T22:21:12Z

Regarding the fetch errors, I have no idea what the issue was. Perhaps just that github was down? Because the project path and the commit hash is valid...

kraj · 2020-01-07T05:37:02Z

merged with b2baaae

@cgzones

Fixes build with 32 bit machines. - Fix build on 32-bit with 64-bit time_t by @cgzones in #136 - Misc by @cgzones in #137 - Add terminating newline also for TLS connections by @Googulator in #139 - Add RFC5425 length field by @derobert in #140 - Correct examples for ExcludeSyslogFacility and ExcludeSyslogLevel by @ngraziano in #141 Signed-off-by: Anuj Mittal <anuj.mittal@oss.qualcomm.com>

sangelovic changed the title ~~Introduce recipe for sdbus-c++ library and its tools~~ [meta-oe] Introduce recipe for sdbus-c++ library and its tools Jun 12, 2019

kraj requested changes Jun 15, 2019

View reviewed changes

meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools-native_0.7.1.bb Outdated Show resolved Hide resolved

meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools-native_0.7.1.bb Outdated Show resolved Hide resolved

meta-oe/recipes-core/sdbus-c++/sdbus-c++_0.7.1.bb Outdated Show resolved Hide resolved

sangelovic force-pushed the feature/add-sdbus-c++-recipe branch from 9e9b5ba to 10b89cf Compare July 9, 2019 18:52

kraj requested changes Jul 9, 2019

View reviewed changes

shr-project reviewed Jul 10, 2019

View reviewed changes

sangelovic force-pushed the feature/add-sdbus-c++-recipe branch from f70a3fd to f9de9cb Compare July 22, 2019 09:56

kraj added the feedback waiting response from submitter label Aug 14, 2019

sangelovic changed the title ~~[meta-oe] Introduce recipe for sdbus-c++ library and its tools~~ WIP: [meta-oe] Introduce recipe for sdbus-c++ library and its tools Oct 11, 2019

sangelovic force-pushed the feature/add-sdbus-c++-recipe branch from 52eb608 to d8d8252 Compare October 13, 2019 16:19

sangelovic changed the title ~~WIP: [meta-oe] Introduce recipe for sdbus-c++ library and its tools~~ [meta-oe] Introduce recipe for sdbus-c++ library and its tools Oct 13, 2019

sangelovic requested a review from kraj October 13, 2019 16:45

kraj requested changes Oct 25, 2019

View reviewed changes

sangelovic force-pushed the feature/add-sdbus-c++-recipe branch from d8d8252 to 17f235e Compare November 2, 2019 11:29

sangelovic requested a review from kraj November 10, 2019 16:57

sangelovic force-pushed the feature/add-sdbus-c++-recipe branch from d06a3d1 to c5644ee Compare November 10, 2019 17:20

kraj requested changes Nov 10, 2019

View reviewed changes

sangelovic force-pushed the feature/add-sdbus-c++-recipe branch from c5644ee to 84f705c Compare January 5, 2020 22:02

sdbus-c++: Introduce recipes for sdbus-c++ library and its tools

64b9e69

sdbus-c++ is a high-level, expressive, easy-to-use C++ D-Bus client library written on top of systemd D-Bus client C library. Signed-off-by: Stanislav Angelovic <angelovic.s@gmail.com>

sangelovic force-pushed the feature/add-sdbus-c++-recipe branch from 84f705c to 64b9e69 Compare January 5, 2020 22:17

kraj closed this Jan 7, 2020


		inherit cmake pkgconfig systemd ptest python3native

		DEPENDS += "expat ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', 'meson-native ninja-native git-native gperf-native gettext-native util-linux glibc libcap', d)}"

Conversation

sangelovic commented Jun 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sangelovic commented Jul 9, 2019

Uh oh!

kraj commented Jul 9, 2019

Uh oh!

sangelovic commented Jul 9, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sangelovic Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sangelovic commented Jul 20, 2019

Uh oh!

kraj commented Jul 22, 2019

Uh oh!

sangelovic commented Jul 22, 2019

Uh oh!

kraj commented Jul 23, 2019

Uh oh!

sangelovic commented Jul 23, 2019 via email

Uh oh!

kraj commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kraj commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sangelovic commented Jul 23, 2019 via email

Uh oh!

kraj commented Jul 23, 2019

Uh oh!

kraj commented Aug 14, 2019

Uh oh!

sangelovic commented Aug 14, 2019 via email

sangelovic commented Jun 12, 2019 •

edited

Loading

sangelovic Jul 10, 2019 •

edited

Loading

kraj commented Jul 23, 2019 •

edited

Loading

kraj commented Jul 23, 2019 •

edited

Loading

sangelovic commented Nov 10, 2019 •

edited

Loading