Skip to content

fix: update links in head and *isLoaded to true #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamstankiewicz merged 1 commit into from
Dec 9, 2023
Merged

fix: update links in head and *isLoaded to true #534

adamstankiewicz merged 1 commit into from
Dec 9, 2023

Conversation

@monteri
Copy link

@monteri monteri commented Aug 9, 2023

Description:

Describe what this pull request changes, and why. Include implications for people using this change.

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 9, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 9, 2023 •
edited
Loading

Thanks for the pull request, @monteri! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@monteri monteri requested a review from adamstankiewicz August 9, 2023 15:46
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.74% ⚠️

Comparison is base (cf10278) 79.05% compared to head (7c69d2a) 78.31%.

Additional details and impacted files 
@@                   Coverage Diff                    @@
##           ags/inject-theme-css     #534      +/-   ##
========================================================
- Coverage                 79.05%   78.31%   -0.74%     
========================================================
  Files                        48       48              
  Lines                      1351     1365      +14     
  Branches                    283      286       +3     
========================================================
+ Hits                       1068     1069       +1     
- Misses                      251      262      +11     
- Partials                     32       34       +2
Files Changed Coverage Δ
src/react/hooks/paragon/useParagonThemeVariants.js 75.00% <0.00%> (-3.65%) ⬇️
src/react/hooks/paragon/useParagonThemeCore.js 74.39% <20.00%> (-7.81%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

mphilbrick211 commented Sep 12, 2023

Hi @monteri! Just flagging that there's a couple failing checks.

@mphilbrick211
Copy link

mphilbrick211 commented Oct 3, 2023

Hi @monteri! Just flagging that there's a couple failing checks.

Hi @monteri! Friendly ping on this.

@monteri
Copy link
Author

monteri commented Oct 10, 2023

@mphilbrick211 Hello, thank you for the ping! It is PR into the another PR. On the point of the failing checks I will discuss next steps with @adamstankiewicz

@mphilbrick211
Copy link

mphilbrick211 commented Nov 14, 2023

Hi @monteri - could you try rebasing this PR? It might help the codecov checks pass. If it doesn't work, I'll look into it for you.

@Mashal-m
Copy link
Contributor

Mashal-m commented Nov 17, 2023

Hey @monteri, What is the current status of this PR, is it ready to review and merge?

@adamstankiewicz adamstankiewicz merged commit 8f0edb4 into openedx:ags/inject-theme-css Dec 9, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 9, 2023

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Dec 9, 2023

@Mashal-m Thanks for checking in on this PR. It's a bug fix against the branch in #440.

dcoa pushed a commit to eduNEXT/frontend-platform that referenced this pull request Dec 30, 2023
@monteri @dcoa
fix: update links in head and *isLoaded to true (openedx#534)
3cca2a9 
Co-authored-by: monteri <lansevermore>
dcoa pushed a commit to eduNEXT/frontend-platform that referenced this pull request Jan 3, 2024
@monteri @dcoa
fix: update links in head and *isLoaded to true (openedx#534)
2497697 
Co-authored-by: monteri <lansevermore>
dcoa pushed a commit to eduNEXT/frontend-platform that referenced this pull request Apr 4, 2024
@monteri @dcoa
fix: update links in head and *isLoaded to true (openedx#534)
e2bbac5 
Co-authored-by: monteri <lansevermore>
dcoa pushed a commit to eduNEXT/frontend-platform that referenced this pull request May 8, 2024
@monteri @dcoa
chore: update package-lock.json
8aafe46 
fix: update links in head and *isLoaded to true (openedx#534)

Co-authored-by: monteri <lansevermore>
bra-i-am pushed a commit to eduNEXT/frontend-platform that referenced this pull request Aug 9, 2024
@monteri @bra-i-am
fix: update links in head and *isLoaded to true (openedx#534)
c85cefb 
Co-authored-by: monteri <lansevermore>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@monteri @openedx-webhooks @mphilbrick211 @Mashal-m @adamstankiewicz