Skip to content

convolutional.cfg added with test data. Relating PR #16358#698

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
ashishkrshrivastava:3.4modified
Jan 22, 2020
Merged

convolutional.cfg added with test data. Relating PR #16358#698
opencv-pushbot merged 1 commit intoopencv:3.4from
ashishkrshrivastava:3.4modified

Conversation

@ashishkrshrivastava
Copy link
Copy Markdown
Contributor

@ashishkrshrivastava ashishkrshrivastava commented Jan 15, 2020 •
edited
Loading

This PR adds 2-layer convolutional model with test data.

@ashishkrshrivastava ashishkrshrivastava mentioned this pull request Jan 15, 2020
Merged
@ashishkrshrivastava ashishkrshrivastava changed the title convolutional.cfg added with test data. Relating PR #16342 convolutional.cfg added with test data. Relating PR #16358 Jan 15, 2020
dkurt
dkurt reviewed Jan 15, 2020
View reviewed changes
@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 15, 2020

darknet/convolutional.cfg_in.npy

Test expecting other names:

  • convolutional_in.npy
  • convolutional_out.npy

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jan 15, 2020

Looks like this is first test with weighted network from Darknet. So we need to save convolutional.weights as well.

@ashishkrshrivastava
Copy link
Copy Markdown
Contributor Author

ashishkrshrivastava commented Jan 16, 2020

Looks like this is first test with weighted network from Darknet. So we need to save convolutional.weights as well.

@dkurt , convolutional.weights added.

@ashishkrshrivastava
Copy link
Copy Markdown
Contributor Author

ashishkrshrivastava commented Jan 18, 2020

@alalek @dkurt , is any improvement needed ?

@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 18, 2020

Builds with automatic tests should be green (see main PR). Patches with red builds can't be merged.

alalek
alalek reviewed Jan 19, 2020
View reviewed changes
opencv-pushbot pushed a commit that referenced this pull request Jan 22, 2020
@alalek
Merge pull request #698 from ashishkrshrivastava:3.4modified
5133483
@opencv-pushbot opencv-pushbot merged commit d2cbc2d into opencv:3.4 Jan 22, 2020
@alalek alalek mentioned this pull request Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@dkurt dkurt dkurt left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashishkrshrivastava @alalek @dkurt @opencv-pushbot