Merged
Conversation
dnn: download_models script improvements opencv#1084 Added new features: * Use argument parser and new arguments: * `--cache` directory will be tried before downloading from internet * `--dst` change destination directory * `--list` list all model names * `--cleanup` remove all `tar.gz` files afterwards * Add hierarchy to model structure, now there are regular models which can be downloaded directly and archived models which should be downloaded and then required files will be extracted. Archived files will be checked for existence before downloading whole archive - it allows to populate them from cache and avoid storing archives on disk. * Filters are now case-insensitive and use _contains_ rule for matching, multiple filters can be used in the command line, results will be united. * GDrive object simplified to separate method - allows to reduce repeated download code. Better solution would be to extract all download-store-verify functionality to separate class(es), but I decided to postpone this step for the future improvements. * Use `pathlib.Path` for most paths. I have doubts regarding filter arguments: should we keep them positional arguments or change to keyword arguments (e.g. `--filter`)? Examples: ```.sh # Populate cache and remove archives afterwards (~4Gb) ./download_models.py --dst /data/dnn --cleanup # Download models to the specified folder using cache ./download_models.py --cache /data/dnn --dst $HOME/opencv_extra/testdata/dnn # List all models having face in their name ./download_models.py --list face ```
Extend performance test models
Updated performance test sanity data for PR opencv/opencv:24333.
Add QRCode with byte data and umlaut
Merge with opencv/opencv#24386 Also noted that random seed is added in this pr, so previous data is regenerated to keep consistency.
This was referenced Oct 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main: opencv/opencv#24416
Contrib: opencv/opencv_contrib#3578
#1084 from mshabunin:dl-script-update
#1095 from WanliZhong:extend_perf_net_test
#1104 from definitelyuncertain:CvtRGB2YUV422
#1105 from dkurt:py_return_non_utf8_string
#1107 from fengyuentau:fix_dtype_nary_eltwise
Previous "Merge 4.x": #1102