add model and test data for fixing dtype bug in nary eltwise layers#1107
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Oct 13, 2023
Merged
add model and test data for fixing dtype bug in nary eltwise layers#1107asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov merged 2 commits intoopencv:4.xfrom
Conversation
6 tasks
dkurt
reviewed
Oct 12, 2023
Member
There was a problem hiding this comment.
This file and testdata/dnn/onnx/data/input_gather_shared_indices.npy are empty. Is that required to for a test?
Member
Author
There was a problem hiding this comment.
Also noted that random seed is added in this pr, so previous data is regenerated to keep consistancy.
I added the random seed, and previous data needs to be regenerated.
Member
Author
There was a problem hiding this comment.
Note that they are not empty though, they are +0 Bytes.
Member
There was a problem hiding this comment.
Oh, I see, excuse me. that's a problem of GitHub,
$ du -hs -b testdata/dnn/onnx/data/*gather_shared*
224 testdata/dnn/onnx/data/input_gather_shared_indices.npy
176 testdata/dnn/onnx/data/output_gather_shared_indices.npy
Contributor
|
@dkurt @fengyuentau Is it ready for merge? |
Member
Author
I think yes, all tests are green. |
dkurt
approved these changes
Oct 13, 2023
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Oct 13, 2023
dnn: fix inconsistent input dtype for nary eltwise layers #24386 Resolves #24385 Merge with opencv/opencv_extra#1107 Relates #24092 (comment) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Merged
IskXCr
pushed a commit
to Haosonn/opencv
that referenced
this pull request
Dec 20, 2023
dnn: fix inconsistent input dtype for nary eltwise layers opencv#24386 Resolves opencv#24385 Merge with opencv/opencv_extra#1107 Relates opencv#24092 (comment) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
dnn: fix inconsistent input dtype for nary eltwise layers opencv#24386 Resolves opencv#24385 Merge with opencv/opencv_extra#1107 Relates opencv#24092 (comment) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
dnn: fix inconsistent input dtype for nary eltwise layers opencv#24386 Resolves opencv#24385 Merge with opencv/opencv_extra#1107 Relates opencv#24092 (comment) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with opencv/opencv#24386
Also noted that random seed is added in this pr, so previous data is regenerated to keep consistancy.