Merged
Conversation
alalek
reviewed
Jun 25, 2022
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
| */ | ||
|
|
||
| CV_WRAP virtual void loadFontData(String fontFileName, int id) = 0; | ||
| CV_WRAP virtual void loadFontData(String fontFileName, long idx) = 0; |
Member
There was a problem hiding this comment.
long
This type is not well supported by OpenCV bindings (Python/Java/etc)
int32_t has the same problem. It is better to keep int.
Contributor
Author
There was a problem hiding this comment.
Because it has side effects, I agree to revert to the unfixed code.
Thank you for your comment !
modules/freetype/test/test_basic.cpp
Outdated
| putText(dst, "LINE_8 putText(th=2)" , Point( 240,565),FONT_HERSHEY_SIMPLEX, 0.5, col, 2, LINE_8); | ||
| putText(dst, "LINE_AA putText(th=2)", Point( 240,580),FONT_HERSHEY_SIMPLEX, 0.5, col, 2, LINE_AA); | ||
|
|
||
| #ifdef OUTPUT_FILE |
Member
There was a problem hiding this comment.
We could use if (cvtest::debugLevel > 0) instead.
Details: opencv/opencv#18955
Contributor
Author
There was a problem hiding this comment.
This function is very useful for me !I
I pushed a commit to use it, thank you very much!
- Revert 3rd argument type of loadFontData() to use "int". - Use cvtest::debugLevel instead to OUTPUT_FILE define. - Change type of idx_range list and ctol_range list to use "int". - fix typo.
Contributor
Author
|
Thank you very much!! |
hakaboom
pushed a commit
to hakaboom/opencv_contrib
that referenced
this pull request
Jul 1, 2022
freetype: support 8UC1/8UC4 image * freetype: add parameter test * freetype: support CV_8UC3 and CV_8C4 * freetype:fix for gcc5.4 * freetype: delete newline * freetype:fix for python binding * freetype: Revert 3rd argument type of loadFontData() to use int. - Revert 3rd argument type of loadFontData() to use "int". - Use cvtest::debugLevel instead to OUTPUT_FILE define. - Change type of idx_range list and ctol_range list to use "int". - fix typo.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2009 (Request for 8UC4)
Fix #3276 (Request for 8UC1)
Related opencv/opencv_extra#981
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.