Skip to content

Added VTK 9 support#2549

Merged
alalek merged 3 commits intoopencv:masterfrom
mshabunin:support-vtk9
Jun 5, 2020
Merged

Added VTK 9 support#2549
alalek merged 3 commits intoopencv:masterfrom
mshabunin:support-vtk9

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented May 30, 2020 •
edited
Loading

Related opencv/opencv#17431
Resolves #2555

Note: the code builds but does not work, additional investigation required

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

This was referenced May 30, 2020
Merged
Closed
@mshabunin mshabunin mentioned this pull request Jun 2, 2020
Closed
alalek
alalek reviewed Jun 5, 2020
View reviewed changes
modules/viz/CMakeLists.txt

ocv_target_link_libraries(${the_module} PRIVATE ${VTK_LIBRARIES})

if (VTK_VERSION VERSION_LESS "8.90.0")
Copy link
Copy Markdown
Member

@alalek alalek Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make condition obvious?

  • if(COMMAND vtk_module_autoinit)
  • or if(DEFINED VTK_USE_FILE)

Copy link
Copy Markdown
Contributor Author

@mshabunin mshabunin Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalek , this condition is used in official VTK samples (e.g. https://lorensen.github.io/VTKExamples/site/Cxx/SimpleOperations/DistanceBetweenPoints/#cmakeliststxt).

alalek
alalek approved these changes Jun 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alalek alalek merged commit 169ec66 into opencv:master Jun 5, 2020
@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Jun 8, 2020

@alalek , @asmorkalov , should we backport this patch to 3.4?

@mshabunin mshabunin deleted the support-vtk9 branch June 8, 2020 09:17
philippefoubert pushed a commit to philippefoubert/opencv_contrib that referenced this pull request Jun 20, 2020
@mshabunin @philippefoubert
Merge pull request opencv#2549 from mshabunin:support-vtk9
b177fa8 
* Added VTK 9 support

* viz: tests are non-interactive now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: build/install category: viz feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opencv_test_viz test hangs

2 participants

@mshabunin @alalek