a fix for open issue 4772#9052
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Jul 3, 2017
Merged
Conversation
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
opencv-pushbot
pushed a commit
that referenced
this pull request
Jul 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4772
This pullrequest changes
As described in open issue #4772 (Static build error because of libstdc++ "multiple definitions"), this error still exists in current opencv 3.2.0.
When
BUILD_SHARED_LIBSis turned off,-lstdc++flag will be added to g++. In this case,libstdc++.aandlibstdc++.dll.awill be all linked, as described in the issue 4772, resulting "multiple definitions" error to occur in several places.However, the default settings of g++ compiler in TDM-GCC behaves just rightly, which links runtimes statically by default. So I think this line of code should be ommited at least in MINGW case. In my case, it works in windows 10, TDM-GCC Compiler Suite for Windows GCC 5 Series MinGW-w64 64/32-bit Edition.
As has such a fix, I successfully compiled out static libraries of opencv 3.2.0 without any error. And I have tried
opencv_test_core.exeproduced in the process of the whole building, passing all the tests.