Skip to content

fix a bug(DetectorType never change)#890

Closed
caorong wants to merge 1 commit intoopencv:masterfrom
caorong:patch-1
Closed

fix a bug(DetectorType never change)#890
caorong wants to merge 1 commit intoopencv:masterfrom
caorong:patch-1

Conversation

@caorong
Copy link
Copy Markdown
Contributor

@caorong caorong commented May 16, 2013

changed line218 -> line220
Presentation:
because line 220 give the global variable mDetectorType and in line 230 it will be compared with mDetectorType !!! it will never be unequal ~
fix:
change mDetectorType(previous global var) to a new local var tmpDetectorType

changed line281 -> line220  
Presentation:
because line 220 give the globle var mDetectorType,and in line 230 it will be compared with mDeteorType !!!  it will never be unequal ~
fix:
change mDetectorType(previous globle var) to a new local val tmpDetectorType
@alekcac
Copy link
Copy Markdown
Contributor

alekcac commented May 17, 2013

Kirill, could you please review these modifications in Java sample.

@ghost ghost assigned asmorkalov May 21, 2013
@apavlenko
Copy link
Copy Markdown
Contributor

Alex, could you please review?

@asmorkalov
Copy link
Copy Markdown
Contributor

:shipit:

@SpecLad
Copy link
Copy Markdown

SpecLad commented May 29, 2013

It appears that the same bug is present in the 2.4 branch.
@caorong Could you rebase your patch on top of 2.4 and resubmit?

opencv-pushbot pushed a commit that referenced this pull request Jun 5, 2013
@apavlenko
Copy link
Copy Markdown
Contributor

Merged to 2.4.

@apavlenko apavlenko closed this Jun 5, 2013
@SpecLad SpecLad mentioned this pull request Jun 10, 2013
savuor pushed a commit to nickyu-zhu/opencv that referenced this pull request Oct 27, 2023
* Add cumsum test data

* Generate onnx models from tf via tf2onnx

* Add tf2onnx model generating code

* Add tf and tf2onnx versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants