Multithreaded IPP gaussian blur#8828
Merged
opencv-pushbot merged 2 commits intoopencv:masterfrom Jun 1, 2017
Merged
Conversation
alalek
reviewed
May 31, 2017
Member
alalek
left a comment
There was a problem hiding this comment.
@woodychow Thank you! Any thoughts about my comment below?
modules/imgproc/src/smooth.cpp
Outdated
| CV_INSTRUMENT_FUN_IPP(::ipp::iwiFilterGaussian, &iwSrc, &iwDst, ksize.width, (float)sigma1, ippBorder); | ||
| // IW 2017u2 has bug which doesn't allow use of partial inMem with tiling | ||
| if((((ippBorder.m_borderFlags)&ippBorderInMem) && ((ippBorder.m_borderFlags)&ippBorderInMem) != ippBorderInMem)) { | ||
| return false; |
Member
There was a problem hiding this comment.
- Should we fallback to single-threaded version?
CV_INSTRUMENT_FUN_IPP(::ipp::iwiFilterGaussian, &iwSrc, &iwDst, ksize.width, (float)sigma1, ippBorder);
-
Should we check version macro:
IW_VERSION_COMPLEX <= 20170002(in case of fix in the next release)? -
Should we add new macro for disabled IPP feature here?
#define IPP_DISABLE_FILTERING_INMEM_PARTIAL 1 // IW 2017u2 has bug which doesn't allow use of partial inMem with tiling
Contributor
Author
There was a problem hiding this comment.
I agree with 1. Actually I just copied that logic from ipp_bilateralFilter.
I am not sure about 2 as there is no guarantee that it will be fixed in the next version. Has anyone reported the bug to Intel yet? It seems to me that 3 is the way to go for now.
…filter when the mutlithreaded version cannot be called.
Contributor
Author
|
@alalek, how does the code look now? |
Member
|
@woodychow Looks good to me! Thank you 👍 |
opencv-pushbot
pushed a commit
that referenced
this pull request
Jun 1, 2017
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.