Skip to content

core(test): InputArray invariant problem#8352

Closed
alalek wants to merge 1 commit intoopencv:masterfrom
alalek:inputarray_invariant
Closed

core(test): InputArray invariant problem#8352
alalek wants to merge 1 commit intoopencv:masterfrom
alalek:inputarray_invariant

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Mar 10, 2017

WIP

Regression test only.
There is no fix yet.

Related #8341 #8149

@vpisarev vpisarev self-assigned this Mar 10, 2017
@vpisarev
Copy link
Copy Markdown
Contributor

@alalek, I don't think there is easy way to fix the problem. One possible solution would be to store Mat itself inside Input/OutputArray, not the pointer to it, but it would noticeably increase the overhead and then we would have to also store UMat, std::vector etc., which would require a type-safe union. I think, we should just document this behaviour. In other words, I do not think that OpenCV can be modified to make the proposed regression test succeed

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Mar 10, 2017

@vpisarev Agreed.
I will think about problem detection instead (before current problem with Canny, there were similar problems with inplaces in cvtColor). Probably for debug mode at least (ABI will be changed).

@vpisarev
Copy link
Copy Markdown
Contributor

So, the options now are: 1) close this PR, 2) disable the tests for now and merge the PR. What do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

future This issue can't be fixed during restrictions of the compatibility requirements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants