Fixed #8149 - Parallel canny on multichannel images#8341
Fixed #8149 - Parallel canny on multichannel images#8341schwittmann wants to merge 1 commit intoopencv:masterfrom
Conversation
|
This patch looks very strange. It doesn't change anything for generic CPU code path, but it probably breaks OpenCL/IPP/OpenVX code paths (because they expect allocated buffers). |
|
The change introduced for the generic CPU code is subtle. If Canny is called with the same input and output matrix (Canny(tmp, tmp...)) then _dst.create() will have side effects on _src. I had a look at the optimized code paths. OpenCL allocates its own buffer and OpenVX is disabled. You are right about your concerns on IPP, at least I can't find an allocation there. Maybe add an additional _dst.create() here? |
This is bad =( |
resolves #8149
This pullrequest changes
As suggested by @mschoeneck in #8149 moving of _dst.create() fixes the problem - if dst gets updated to the newly created matrix, too. opencv_test_imgproc runs fine.