fix installation of main module headers#797
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom May 22, 2013
vhdirk:installheaders
Merged
fix installation of main module headers#797opencv-pushbot merged 1 commit intoopencv:masterfrom vhdirk:installheaders
opencv-pushbot merged 1 commit intoopencv:masterfrom
vhdirk:installheaders
Conversation
see: http://code.opencv.org/issues/2897 The order of the 2 conditions is really important, as every MATCHES operator sets ${CMAKE_MATCH_1}, which is needed inside the condition block. Ideally, this should be done using a single regex with a negative forward lookahead, but CMake doesn't seem to support this
Contributor
|
@taka-no-me Andrey, can you please review the request? |
Contributor
|
Vadim, could you please review this pull request? |
|
I just experienced the same problem reported on the issue tracker and the proposed fix solved the problem perfectly! Im on a windows 8 machine with MinGW gcc 4.7.2 |
Contributor
|
Vadim, any updates? |
Contributor
|
👍 |
apavlenko
pushed a commit
that referenced
this pull request
May 22, 2013
savuor
pushed a commit
to nickyu-zhu/opencv
that referenced
this pull request
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: http://code.opencv.org/issues/2897
The order of the 2 conditions is really important, as every
MATCHESoperator sets${CMAKE_MATCH_1}, which is needed inside the condition block.Ideally, this should be done using a single regex with a negative forward lookahead, but CMake doesn't seem to support this...