You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also using namespace std; is prohibited in master as we already started a work on STL dependency removal. So please always explicitly qualify all std members with std:: prefix.
This issues aren't a bugs, it is compilation errors. I can fix it separately, but this PR rewrites affected files, so this fixes became unnecessary after this PR.
Legacy version was removed. Only new ogl:: version is available.
@Jet47, @taka-no-me: Namespace ogl is usually used for high level opengl wrappers I think to use such common name is not a good idea. Except ogl related changes I agree with this request.
Please never use "already used" as an argument for not making the code better. And lets discuss the usage of namespaces in 2.5 on today's meeting. This question is wider then current debates on ogl namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes weren't merged from 2.4 branch into master.