PnP solver: fixed element-wise access#3157
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Aug 25, 2014
Merged
Conversation
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the big PnP update, the data was stored row-first (n points in one single line). Now, the RansacCallback is used which stores column-first (one single point in n lines). This led to an debug assertion failing when using any other method than SOLVEPNP_ITERATIVE (in release mode, the access did work correctly since the next memory cell contains the next value regardless of column- or row-first). To fix this bug and to be storage-agnostic, we now use the single-paramenter element access (since in all cases we have either one row or one column).