Fix regression in findChessboardCorners (issue #28028)#28471
Open
Tzila-m wants to merge 3 commits intoopencv:4.xfrom
Open
Fix regression in findChessboardCorners (issue #28028)#28471Tzila-m wants to merge 3 commits intoopencv:4.xfrom
Tzila-m wants to merge 3 commits intoopencv:4.xfrom
Conversation
Contributor
|
Is it intended to be a revert of #25177 PR?
I think something like "revert commit" would be more appropriate if so. Comparing previous (https://github.com/opencv/opencv/pull/25177/changes) with current changes (5b5a8c6), I see some changes.
It turns out that these changes correspond to reverting ff9aeac and bcbc74d |
Contributor
|
@s-trinh Thanks a lot for analysis. |
Author
|
Test data added in opencv_extra PR #1315 |
added 3 commits
January 29, 2026 13:45
…sboardCorners This change fixes a regression introduced after PR opencv#25177, where certain adaptive threshold and dilation combinations were unintentionally skipped during chessboard detection. The updated logic restores the missing block_size and dilation combinations that were evaluated in OpenCV 4.8, without fully reverting the changes introduced later. A regression test reproducing issue opencv#28028 is included. Fixes opencv#28028 Related to opencv#25177
…: opencv_extra/testdata/calib3d opencv#28028
902be5a to
28e09d2
Compare
Author
|
I realized that there is a repository for images for tests, I opened a PR in opencv_extra with the image opencv/opencv_extra#1315 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts PR #25177, which introduced a regression in findChessboardCorners.
Also a test with a new chessboard image is added.
Details
The regression appears after changes introduced in PR #25177 and is reproducible on the input image provided in issue #28028.
The current implementation skips some threshold/dilation combinations compared to the previous behavior, which can lead to missed detections in certain cases.
Fixes #28028
Related to #25177