Skip to content

TFLite fixes for Face Blendshapes V2#27307

Merged
asmorkalov merged 11 commits intoopencv:4.xfrom
dkurt:tflite_face_blendshape_model
May 19, 2025
Merged

TFLite fixes for Face Blendshapes V2#27307
asmorkalov merged 11 commits intoopencv:4.xfrom
dkurt:tflite_face_blendshape_model

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented May 14, 2025 •
edited
Loading

Pull Request Readiness Checklist

  • Scalars support
  • Better handling of 1D tensors
  • New ops import: SUB, SQRT, DIV, NEG, SQUARED_DIFFERENCE, SUM
  • Number of NHWC<->NCHW layouts compatibility improvements

resolves #27211

Merge with extra: opencv/opencv_extra#1257

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dkurt dkurt changed the title TFLite fixes for Face Blendmesh V2 TFLite fixes for Face Blendshapes V2 May 14, 2025
@dkurt dkurt force-pushed the tflite_face_blendshape_model branch from 1cc6f5c to a9fd554 Compare May 14, 2025 06:06
@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented May 14, 2025

@asmorkalov can you please check macOS-ARM64-Vulkan / BuildAndTest ?

Run DOWNLOAD_MODELS_FILE='download_models.py'
Updating DNN models list
This script requires 'requests' library
Error: Process completed with exit code 13.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 14, 2025

cc @avdivan

@asmorkalov asmorkalov added this to the 4.12.0 milestone May 14, 2025
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 15, 2025

CUDA:

[ RUN      ] Test_TFLite.face_blendshapes/0, where GetParam() = CUDA/CUDA
unknown file: Failure
C++ exception with description "OpenCV(4.12.0-dev) /home/ci/opencv/modules/dnn/src/layers/../cuda4dnn/primitives/../csl/tensor_ops.hpp:43: error: (-215:Assertion failed) is_shape_same(dest, src) in function 'copy'
" thrown in the test body.
[  FAILED  ] Test_TFLite.face_blendshapes/0, where GetParam() = CUDA/CUDA (43 ms)
[ RUN      ] Test_TFLite.face_blendshapes/1, where GetParam() = CUDA/CUDA_FP16
unknown file: Failure
C++ exception with description "OpenCV(4.12.0-dev) /home/ci/opencv/modules/dnn/src/layers/../cuda4dnn/primitives/../csl/tensor_ops.hpp:43: error: (-215:Assertion failed) is_shape_same(dest, src) in function 'copy'
" thrown in the test body.
[  FAILED  ] Test_TFLite.face_blendshapes/1, where GetParam() = CUDA/CUDA_FP16 (50 ms)

dkurt
dkurt commented May 16, 2025
View reviewed changes
@dkurt dkurt force-pushed the tflite_face_blendshape_model branch from 20e5a57 to c7f911d Compare May 16, 2025 09:34
@dkurt dkurt marked this pull request as ready for review May 16, 2025 14:45
@asmorkalov asmorkalov self-assigned this May 19, 2025
@asmorkalov asmorkalov merged commit 1e3ab44 into opencv:4.x May 19, 2025
75 of 82 checks passed
@dkurt dkurt deleted the tflite_face_blendshape_model branch May 19, 2025 07:48
@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Merged
@dkurt dkurt mentioned this pull request Jun 12, 2025
Merged
6 tasks
asmorkalov pushed a commit that referenced this pull request Jun 13, 2025
@dkurt
Merge pull request #27439 from dkurt:tflite_fixes_for_new_engine
2e6a0ca 
Adoptions of TFLife fixes to new engine #27439

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

This PR covers updates from the following PRs:
#27273, #27307 (ported to 5.x by #27370)

resolves #27397

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: dnn feature

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

tflite scalar support

2 participants

@dkurt @asmorkalov