Skip to content

Bug fix unstable crf#27270

Merged
asmorkalov merged 5 commits intoopencv:4.xfrom
gursimarsingh:bug_fix_unstable_crf
May 21, 2025
Merged

Bug fix unstable crf#27270
asmorkalov merged 5 commits intoopencv:4.xfrom
gursimarsingh:bug_fix_unstable_crf

Conversation

@gursimarsingh
Copy link
Copy Markdown
Contributor

@gursimarsingh gursimarsingh commented Apr 30, 2025 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

The PR resolves the issue for triangle Weights used by debevec algorithm being non zero at extremes.
It resolves #24966

The fix needs ground truth data to be changed in order to pass existing tests. PR to opencv_extra: opencv/opencv_extra#1253

This was referenced Apr 30, 2025
Merged
Closed
@gursimarsingh gursimarsingh added this to the 4.12.0 milestone Apr 30, 2025
@gursimarsingh gursimarsingh self-assigned this Apr 30, 2025
@asmorkalov asmorkalov self-requested a review May 5, 2025 06:36
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 5, 2025

@gursimarsingh There is still significant instability in results. Several Ubuntu builds as well as Mac produce different values and test fails.

@gursimarsingh
Copy link
Copy Markdown
Contributor Author

gursimarsingh commented May 5, 2025

Yes, @asmorkalov I am reviewing it for other platforms. Result vary significantly in between different OS versions. I am trying to create dockers locally to mimic the CI test failures and debug them.

@gursimarsingh gursimarsingh force-pushed the bug_fix_unstable_crf branch from 6f1641d to 34d12bb Compare May 13, 2025 08:02
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 15, 2025

Windows CI:

 [ RUN      ] Photo_CalibrateDebevec.regression
C:\GHA-OCV-1\_work\opencv\opencv\opencv\modules\photo\test\test_hdr.cpp(230): error: Expected: (max) < (0.1), actual: 0.20345 vs 0.1
[  FAILED  ] Photo_CalibrateDebevec.regression (10934 ms)

Docs CI warning may be ignored most probably.

@asmorkalov asmorkalov requested review from vpisarev and removed request for asmorkalov May 15, 2025 15:37
@asmorkalov asmorkalov assigned vpisarev and unassigned asmorkalov May 19, 2025
asmorkalov pushed a commit to opencv/opencv_extra that referenced this pull request May 21, 2025
@gursimarsingh
Merge pull request #1253 from gursimarsingh:bug_fix_unstable_crf
8926a39 
added updated test data for fixing bug 24966

This PR updates the test data required to fix this [bug](opencv/opencv#24966). This is necessary to pass the tests in this [PR](opencv/opencv#27270).
@asmorkalov asmorkalov added the bug label May 21, 2025
@asmorkalov asmorkalov merged commit c3fe92d into opencv:4.x May 21, 2025
28 of 55 checks passed
@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@vpisarev vpisarev

Labels

bug category: photo

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

HDR CalibrateDebevec: triangleWeights() should be 0 at limits

4 participants

@gursimarsingh @asmorkalov @vpisarev @abhishek-gola