Skip to content

Fix configuring with CMake version 4#27192

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
ddennedy:cmake4
Apr 16, 2025
Merged

Fix configuring with CMake version 4#27192
asmorkalov merged 1 commit intoopencv:4.xfrom
ddennedy:cmake4

Conversation

@ddennedy
Copy link
Copy Markdown
Contributor

@ddennedy ddennedy commented Apr 3, 2025

fixes #27122

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

I did not test every configuration and build option, module, and sample. All I did was search all the code for cmake_minimum_required, look for ones less than 3.5, and bump them. I can report that my build like below succeeded with my branch:
cmake -B build -G Ninja -D CMAKE_INSTALL_PREFIX=$FINAL_INSTALL_DIR -D BUILD_LIST=tracking -D OPENCV_GENERATE_PKGCONFIG=YES -D OPENCV_EXTRA_MODULES_PATH=../opencv_contrib/modules -D WITH_OPENMP=ON

(Yes, I do prefer to separate my -Ds from the option.)

@asmorkalov
Copy link
Copy Markdown
Contributor

@mshabunin Could you take a look?

ziyao233 pushed a commit to ziyao233/eweos-packages that referenced this pull request Apr 14, 2025
Rebuild against protobuf 30.2. Add an under-review patch to fix building
with CMake 4.

Reference: opencv/opencv#27122
Link: opencv/opencv#27192
ziyao233 pushed a commit to eweOS/packages that referenced this pull request Apr 15, 2025
Rebuild against protobuf 30.2. Add an under-review patch to fix building
with CMake 4.

Reference: opencv/opencv#27122
Link: opencv/opencv#27192
@asmorkalov asmorkalov merged commit 767dd83 into opencv:4.x Apr 16, 2025
53 of 55 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breakage with CMake 4

3 participants