Skip to content

build: fix OpenBLAS detection on Linux#27029

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
mshabunin:fix-openblas
Apr 1, 2025
Merged

build: fix OpenBLAS detection on Linux#27029
asmorkalov merged 1 commit intoopencv:4.xfrom
mshabunin:fix-openblas

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Mar 8, 2025 •
edited
Loading

Main change is rewritten OpenCVFindOpenBLAS.cmake:

  • search cmake package first
  • search using environment variables second
  • search in system locations last
  • additionally search for lapacke.h and append its path to the result header location

Other changes:

  • use arguments syntax for ocv_lapack_check
  • debug output

Test framework (Linux): https://github.com/mshabunin/opencv-blas-check

Should be merged with opencv/ci-gha-workflow#237

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 9, 2025

Proper BLAS detection affects photo module tests:

 PID: 45146
  [ RUN      ] Photo_CalibrateDebevec.regression
  /home/ubuntu/opencv/modules/photo/test/test_hdr.cpp:233: Failure
  Expected: (max) < (0.1), actual: 0.415381 vs 0.1
  [  FAILED  ] Photo_CalibrateDebevec.regression (1480 ms)

@asmorkalov asmorkalov self-requested a review March 10, 2025 08:32
@asmorkalov asmorkalov self-assigned this Mar 10, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Mar 10, 2025
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 10, 2025

Looks like the following lines affect test result:

opencv/modules/photo/src/calibrate.cpp

Line 150 in 316b5d7

// solve the overdetermined system using SVD (least-squares problem) 

            // solve the overdetermined system using SVD (least-squares problem)
            Mat solution;
            solve(A, B, solution, DECOMP_SVD);

@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Mar 10, 2025

Yes, apparently SVD differs between the libraries. I'm not sure how we should handle this...

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 24, 2025

Related PR: #19343

@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Mar 31, 2025

CI has passed with updated ubuntu 24 docker image (opencv/ci-gha-workflow#237), I'm reverting CI branch.

@mshabunin mshabunin mentioned this pull request Mar 31, 2025
Merged
@asmorkalov asmorkalov merged commit 8b4b382 into opencv:4.x Apr 1, 2025
27 of 28 checks passed
@mshabunin mshabunin deleted the fix-openblas branch April 1, 2025 07:50
@mshabunin mshabunin mentioned this pull request Apr 19, 2025
Merged
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Merged
asmorkalov pushed a commit that referenced this pull request May 12, 2025
@mshabunin
Merge pull request #27243 from mshabunin:fix-openblas-5x
cb87f05 
Port of #27029 to 5.x

Replaced search mechanism with 4.x variant
@marcoffee marcoffee mentioned this pull request Sep 6, 2025
Closed
4 tasks
@MichaelYochpaz MichaelYochpaz mentioned this pull request Nov 20, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mshabunin @asmorkalov