Skip to content

Fix assertion in cv2.sampsonDistance #26921

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
shyama7004:sampsonDistance
Feb 17, 2025
Merged

Fix assertion in cv2.sampsonDistance #26921
asmorkalov merged 1 commit intoopencv:4.xfrom
shyama7004:sampsonDistance

Conversation

@shyama7004
Copy link
Copy Markdown
Contributor

@shyama7004 shyama7004 commented Feb 14, 2025 •
edited
Loading

Fixes : #25370

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

asmorkalov
asmorkalov requested changes Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentioned PR contains very good test code. I propose to drop redundant dimension in test data and add it to https://github.com/opencv/opencv/blob/4.x/modules/calib3d/misc/python/test/test_calibration.py

@asmorkalov asmorkalov self-assigned this Feb 14, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Feb 14, 2025
@shyama7004 shyama7004 force-pushed the sampsonDistance branch 2 times, most recently from 750f1f1 to 416b6b2 Compare February 14, 2025 21:42
@asmorkalov asmorkalov merged commit 8065f10 into opencv:4.x Feb 17, 2025
26 of 29 checks passed
@shyama7004 shyama7004 deleted the sampsonDistance branch February 17, 2025 07:18
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: python bindings test

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

Unexpect error when invoke cv2.sampsonDistance

2 participants

@shyama7004 @asmorkalov