Skip to content

Support 64-bit integer types for FileStorage Base64#26871

Merged
asmorkalov merged 5 commits intoopencv:5.xfrom
MaximSmolskiy:fix-filestorage_io_test-test_base64-for-64-bit-integer-types
Feb 6, 2025
Merged

Support 64-bit integer types for FileStorage Base64#26871
asmorkalov merged 5 commits intoopencv:5.xfrom
MaximSmolskiy:fix-filestorage_io_test-test_base64-for-64-bit-integer-types

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

@MaximSmolskiy MaximSmolskiy commented Feb 2, 2025 •
edited by asmorkalov
Loading

Pull Request Readiness Checklist

Related to #26846 (comment)
OpenCV extra: opencv/opencv_extra#1232

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

asmorkalov
asmorkalov reviewed Feb 3, 2025
View reviewed changes
@asmorkalov asmorkalov added this to the 5.0-release milestone Feb 3, 2025
@asmorkalov asmorkalov self-assigned this Feb 3, 2025
@MaximSmolskiy MaximSmolskiy changed the title Fix filestorage_io_test.test_base64 for 64-bit integer types Support 64-bit integer types for FileStorage Base64 Feb 5, 2025
@vpisarev vpisarev self-requested a review February 5, 2025 14:22
@vpisarev vpisarev self-requested a review February 5, 2025 14:23
vpisarev
vpisarev requested changes Feb 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vpisarev vpisarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some core tests fail

@MaximSmolskiy MaximSmolskiy mentioned this pull request Feb 5, 2025
Merged
@MaximSmolskiy
Copy link
Copy Markdown
Contributor Author

MaximSmolskiy commented Feb 5, 2025

Tried to fix Core_InputOutput.filestorage_base64_basic_read_* tests by updating test data in opencv_extra repository - opencv/opencv_extra#1232

@MaximSmolskiy
Copy link
Copy Markdown
Contributor Author

MaximSmolskiy commented Feb 6, 2025

Tried to fix Core_InputOutput.filestorage_base64_basic_read_* tests by updating test data in opencv_extra repository - opencv/opencv_extra#1232

It seems 4 green pipelines have been added, tried to fix following errors

@MaximSmolskiy
Copy link
Copy Markdown
Contributor Author

MaximSmolskiy commented Feb 6, 2025

It seems 6 green pipelines have been added, this should be last try

@asmorkalov asmorkalov merged commit 8badff5 into opencv:5.x Feb 6, 2025
24 of 25 checks passed
@MaximSmolskiy MaximSmolskiy deleted the fix-filestorage_io_test-test_base64-for-64-bit-integer-types branch February 6, 2025 15:47
asmorkalov pushed a commit to opencv/opencv_extra that referenced this pull request Feb 6, 2025
@MaximSmolskiy
Merge pull request #1232 from MaximSmolskiy:fix-filestorage_io_test-t…
768bc48 
…est_base64-for-64-bit-integer-types

Support 64-bit integer types for FileStorage Base64 #1232

Related to opencv/opencv#26871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@asmorkalov asmorkalov

Labels

category: core category: python bindings

Projects

None yet

Milestone

5.0-release

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximSmolskiy @vpisarev @asmorkalov