Skip to content

Update OpenCVFindWebP.cmake with sturkmen72's suggestion#26857

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
hmaarrfk:patch-1
Feb 1, 2025
Merged

Update OpenCVFindWebP.cmake with sturkmen72's suggestion#26857
asmorkalov merged 1 commit intoopencv:4.xfrom
hmaarrfk:patch-1

Conversation

@hmaarrfk
Copy link
Copy Markdown
Contributor

@hmaarrfk hmaarrfk commented Jan 30, 2025 •
edited by asmorkalov
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@hmaarrfk
Update OpenCVFindWebP.cmake with sturkmen72's suggestion
2a0092c 
@sturkmen72  feel free to fold into opencv#26762 but I would just like a dedicated patch to try.
@hmaarrfk
Copy link
Copy Markdown
Contributor Author

hmaarrfk commented Jan 30, 2025

hmm i don't think the patch worked FYI.

@sturkmen72
Copy link
Copy Markdown
Contributor

sturkmen72 commented Jan 30, 2025 •
edited
Loading

@hmaarrfk i guess there should be some where in your configuration BUILD_WEBP=OFF. with this patch when i set BUILD_WEBP=OFF works fine

OCV_OPTION(BUILD_ZLIB               "Build zlib from source"             (WIN32 OR APPLE OR OPENCV_FORCE_3RDPARTY_BUILD) )
OCV_OPTION(BUILD_TIFF               "Build libtiff from source"          (WIN32 OR ANDROID OR APPLE OR OPENCV_FORCE_3RDPARTY_BUILD) )
OCV_OPTION(BUILD_WEBP               "Build WebP from source"             (((WIN32 OR ANDROID OR APPLE) AND NOT WINRT) OR OPENCV_FORCE_3RDPARTY_BUILD) )

i think you already set BUILD_ZLIB and BUILD_TIFF to 0

// Build libtiff from source
BUILD_TIFF:BOOL=0

// Build WebP from source
BUILD_WEBP:BOOL=ON

// Build zlib from source
BUILD_ZLIB:BOOL=0

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

hmaarrfk commented Jan 30, 2025

great thank you can confirm it works.

I forgot all the details of opencv compilation /....

@sturkmen72
Copy link
Copy Markdown
Contributor

sturkmen72 commented Jan 30, 2025

great thank you can confirm it works.

I forgot all the details of opencv compilation /....

i think you can set the PR as ready to review

@hmaarrfk hmaarrfk marked this pull request as ready for review January 31, 2025 00:12
@asmorkalov asmorkalov requested a review from vrabaud January 31, 2025 13:43
@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 31, 2025
@asmorkalov asmorkalov merged commit 43cebe5 into opencv:4.x Feb 1, 2025
29 of 30 checks passed
@asmorkalov asmorkalov mentioned this pull request Feb 1, 2025
Merged
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrabaud vrabaud vrabaud approved these changes

Assignees

@vrabaud vrabaud

Labels

category: build/install category: 3rdparty

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hmaarrfk @sturkmen72 @vrabaud @asmorkalov