Fixed AVIF linkage on Windows by sturkmen72 · Pull Request #26762 · opencv/opencv

sturkmen72 · 2025-01-13T09:14:39Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

sturkmen72 · 2025-01-13T09:38:22Z

to test the PR i compiled libavif on windows using

git clone -b v1.1.1 https://github.com/AOMediaCodec/libavif.git
cmake -S libavif -B libavif/build -DBUILD_SHARED_LIBS=ON -DAVIF_CODEC_AOM=LOCAL -DAVIF_LIBYUV=LOCAL -DAVIF_LIBSHARPYUV=LOCAL -DAVIF_JPEG=OFF -DAVIF_ZLIBPNG=OFF -DAVIF_BUILD_APPS=OFF
cmake --build libavif/build --config Release --target install
set PATH=%PATH%;C:\Program Files (x86)\libavif

the output of cmake when compiling OpenCV

--   Media I/O:
--     ZLib-Ng:                     build (zlib ver 1.3.1.zlib-ng, zlib-ng ver 2.2.1)
--     JPEG:                        build-libjpeg-turbo (ver 3.0.3-70)
--       SIMD Support Request:      YES
--       SIMD Support:              YES
--     WEBP:                        build (ver decoder: 0x0209, encoder: 0x020f, demux: 0x0107)
--     AVIF:                        avif (ver 1.1.1)
--     PNG:                         build (ver 1.6.43)
--       SIMD Support Request:      YES
--       SIMD Support:              YES (Intel SSE)
--     JPEG XL:                     NO
--     JPEG 2000:                   build (ver 2.5.0)
--     GIF:                         YES
--     HDR:                         YES
--     SUNRASTER:                   YES
--     PXM:                         YES
--     PFM:                         YES

git clone -b v1.1.1 https://github.com/AOMediaCodec/libavif.git
cmake -S libavif -B libavif/build -DBUILD_SHARED_LIBS=OFF -DAVIF_CODEC_AOM=LOCAL -DAVIF_LIBYUV=LOCAL -DAVIF_LIBSHARPYUV=LOCAL -DAVIF_JPEG=OFF -DAVIF_ZLIBPNG=OFF -DAVIF_BUILD_APPS=OFF
cmake --build libavif/build --config Release --target install
set PATH=%PATH%;C:\Program Files (x86)\libavif

--   Media I/O:
--     ZLib-Ng:                     build (zlib ver 1.3.1.zlib-ng, zlib-ng ver 2.2.1)
--     JPEG:                        build-libjpeg-turbo (ver 3.0.3-70)
--       SIMD Support Request:      YES
--       SIMD Support:              YES
--     WEBP:                        build (ver decoder: 0x0209, encoder: 0x020f, demux: 0x0107)
--     AVIF:                        C:/Program Files (x86)/libavif/lib/avif.lib
--     PNG:                         build (ver 1.6.43)
--       SIMD Support Request:      YES
--       SIMD Support:              YES (Intel SSE)
--     JPEG XL:                     NO
--     JPEG 2000:                   build (ver 2.5.0)
--     GIF:                         YES
--     HDR:                         YES
--     SUNRASTER:                   YES
--     PXM:                         YES
--     PFM:                         YES

also tested with with loaded libs by vcpkg

--   Media I/O:
--     ZLib-Ng:                     build (zlib ver 1.3.1.zlib-ng, zlib-ng ver 2.2.1)
--     JPEG:                        build-libjpeg-turbo (ver 3.0.3-70)
--       SIMD Support Request:      YES
--       SIMD Support:              YES
--     WEBP:                        build (ver decoder: 0x0209, encoder: 0x020f, demux: 0x0107)
--     AVIF:                        yuv unofficial::aom $<$<NOT:$<CONFIG:DEBUG>>:C:/GitHub/vcpkg/installed/x64-windows-static/lib/dav1d.lib> $<$<CONFIG:DEBUG>:C:/GitHub/vcpkg/installed/x64-windows-static/debug/lib/dav1d.lib> avif (ver 1.1.1)
--     PNG:                         build (ver 1.6.43)
--       SIMD Support Request:      YES
--       SIMD Support:              YES (Intel SSE)
--     JPEG XL:                     C:/GitHub/vcpkg/installed/x64-windows-static/lib/jxl.lib C:/GitHub/vcpkg/installed/x64-windows-static/lib/jxl_cms.lib C:/GitHub/vcpkg/installed/x64-windows-static/lib/lcms2.lib C:/GitHub/vcpkg/installed/x64-windows-static/lib/jxl_threads.lib C:/GitHub/vcpkg/installed/x64-windows-static/lib/brotlidec.lib C:/GitHub/vcpkg/installed/x64-windows-static/lib/brotlienc.lib C:/GitHub/vcpkg/installed/x64-windows-static/lib/brotlicommon.lib C:/GitHub/vcpkg/installed/x64-windows-static/lib/hwy.lib (ver 0.11.1)
--     JPEG 2000:                   build (ver 2.5.0)
--     GIF:                         YES
--     HDR:                         YES
--     SUNRASTER:                   YES
--     PXM:                         YES
--     PFM:                         YES

vrabaud

Thx !

asmorkalov · 2025-01-14T04:48:16Z

I find the solution as dangerous. In case if I want to use custom libavif instead of system one it may lead to libraries mix. I support Maksim's proposal from the original ticket to use target name if it's avaliable. Also you need to take a look on IMPORTED_LOCATION property: https://cmake.org/cmake/help/latest/prop_tgt/IMPORTED_LOCATION.html. Most probably it's right way to go as hot fix.

sturkmen72 · 2025-01-14T09:16:44Z

@asmorkalov let me work on this a bit more

sturkmen72 · 2025-01-29T05:41:59Z

@asmorkalov please review. I know it's not perfect but it's all I can do.

hmaarrfk · 2025-01-30T05:36:30Z

This seems to resolve the issues at conda-forge

sturkmen72 · 2025-01-30T12:48:52Z

@asmorkalov @mshabunin for your interest https://github.com/conda-forge/opencv-feedstock/pull/448/files#diff-d24508ea6935080f69d537d0407e177ff043942143be8e8c836202bc37303ca5

cmake/OpenCVFindAVIF.cmake

sturkmen72 · 2025-01-30T20:23:48Z

@mshabunin @hmaarrfk what about updating also OpenCVFindWebP.cmake in this PR

#=============================================================================
# Find WebP library
#=============================================================================
# Find the native WebP headers and libraries.
#
#  WEBP_INCLUDE_DIRS - where to find webp/decode.h, etc.
#  WEBP_LIBRARIES    - List of libraries when using webp.
#  WEBP_FOUND        - True if webp is found.
#=============================================================================

# Look for the header file.

unset(WEBP_FOUND)

find_package(WebP QUIET)

if(TARGET WebP::webp AND TARGET WebP::webpdemux AND TARGET WebP::libwebpmux)
    MARK_AS_ADVANCED(WEBP_INCLUDE_DIR)
    MARK_AS_ADVANCED(WEBP_LIBRARY)

    SET(WEBP_FOUND TRUE)
    SET(WEBP_LIBRARY WebP)
    SET(WEBP_INCLUDE_DIR)
else()
    MARK_AS_ADVANCED(WEBP_INCLUDE_DIR)

    # Look for the library.
    FIND_LIBRARY(WEBP_LIBRARY NAMES webp)
    FIND_LIBRARY(WEBP_MUX_LIBRARY NAMES webpmux)
    FIND_LIBRARY(WEBP_DEMUX_LIBRARY NAMES webpdemux)

    # handle the QUIETLY and REQUIRED arguments and set WEBP_FOUND to TRUE if
    # all listed variables are TRUE
    INCLUDE(${CMAKE_ROOT}/Modules/FindPackageHandleStandardArgs.cmake)
    FIND_PACKAGE_HANDLE_STANDARD_ARGS(WebP DEFAULT_MSG WEBP_LIBRARY WEBP_INCLUDE_DIR)

    SET(WEBP_LIBRARIES ${WEBP_LIBRARY} ${WEBP_MUX_LIBRARY} ${WEBP_DEMUX_LIBRARY})
    SET(WEBP_INCLUDE_DIRS ${WEBP_INCLUDE_DIR})
endif()

hmaarrfk · 2025-01-30T20:26:44Z

@mshabunin @hmaarrfk what about updating also OpenCVFindWebP.cmake in this PR

I strongly suggest you don't grow the scope of this PR to ensure it gets through.

However, the exact workflow is up to the OpenCV team. I'm just an onlooker.

sturkmen72 · 2025-01-30T20:37:54Z

@hmaarrfk OK. I noticed that in your build process, only webp was not found

--   Media I/O: 
--     ZLib:                        D:/bld/libopencv_1738263879095/_h_env/Library/lib/z.lib (ver 1.3.1)
--     JPEG:                        D:/bld/libopencv_1738263879095/_h_env/Library/lib/jpeg.lib (ver 80)
--     WEBP:                        build (ver decoder: 0x0209, encoder: 0x020f, demux: 0x0107)
--     AVIF:                        avif (ver 1.1.1)
--     PNG:                         D:/bld/libopencv_1738263879095/_h_env/Library/lib/libpng.lib (ver 1.6.46)
--     TIFF:                        (ver 42 / 4.7.0)
--     JPEG 2000:                   D:/bld/libopencv_1738263879095/_h_env/Library/lib/jasper.lib (ver 4.2.4)
--     OpenEXR:                     OpenEXR::OpenEXR (ver 3.3.2)
--     GIF:                         NO
--     HDR:                         YES
--     SUNRASTER:                   YES
--     PXM:                         YES
--     PFM:                         YES

hmaarrfk · 2025-01-30T21:17:29Z

Thank you. i'll investigate and report back.

@sturkmen72

@sturkmen72 feel free to fold into opencv#26762 but I would just like a dedicated patch to try.

Fixed AVIF linkage on Windows opencv#26762 Closes opencv#26747 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake

@sturkmen72

@sturkmen72 feel free to fold into opencv#26762 but I would just like a dedicated patch to try.

asmorkalov requested a review from vrabaud January 13, 2025 10:03

asmorkalov added the category: build/install label Jan 13, 2025

asmorkalov added this to the 4.12.0 milestone Jan 13, 2025

vrabaud approved these changes Jan 13, 2025

View reviewed changes

sturkmen72 marked this pull request as draft January 14, 2025 09:16

sturkmen72 force-pushed the avif_cmake branch 3 times, most recently from bc5a185 to c6b76bc Compare January 21, 2025 14:43

sturkmen72 force-pushed the avif_cmake branch from c6b76bc to 0c9f1a5 Compare January 25, 2025 13:38

sturkmen72 marked this pull request as ready for review January 26, 2025 21:32

sturkmen72 marked this pull request as draft January 27, 2025 13:19

Update OpenCVFindAVIF.cmake

6eb3263

sturkmen72 force-pushed the avif_cmake branch from 0c9f1a5 to 6eb3263 Compare January 29, 2025 05:27

sturkmen72 marked this pull request as ready for review January 29, 2025 05:42

sturkmen72 mentioned this pull request Jan 30, 2025

Problems with Linking avif in Visual Studio #26747

Closed

4 tasks

mshabunin reviewed Jan 30, 2025

View reviewed changes

cmake/OpenCVFindAVIF.cmake Outdated Show resolved Hide resolved

Update OpenCVFindAVIF.cmake

c4deb5f

hmaarrfk mentioned this pull request Jan 30, 2025

opencv v4.11.0 -- drop qt5 - fix webp conda-forge/opencv-feedstock#448

Merged

3 tasks

hmaarrfk added a commit to hmaarrfk/opencv that referenced this pull request Jan 30, 2025

Update OpenCVFindWebP.cmake with sturkmen72's suggestion

2a0092c

@sturkmen72 feel free to fold into opencv#26762 but I would just like a dedicated patch to try.

hmaarrfk mentioned this pull request Jan 30, 2025

Update OpenCVFindWebP.cmake with sturkmen72's suggestion #26857

Merged

6 tasks

asmorkalov approved these changes Jan 31, 2025

View reviewed changes

asmorkalov changed the title ~~Proposed solution for Issue 26747~~ Fixed AVIF linkage on Windows Jan 31, 2025

asmorkalov self-assigned this Jan 31, 2025

asmorkalov merged commit fbd2105 into opencv:4.x Jan 31, 2025
29 of 30 checks passed

sturkmen72 deleted the avif_cmake branch January 31, 2025 15:12

asmorkalov mentioned this pull request Feb 19, 2025

5.x merge 4.x #26939

Merged

NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025

Update OpenCVFindWebP.cmake with sturkmen72's suggestion

21286a5

@sturkmen72 feel free to fold into opencv#26762 but I would just like a dedicated patch to try.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed AVIF linkage on Windows#26762

Fixed AVIF linkage on Windows#26762
asmorkalov merged 2 commits intoopencv:4.xfrom
sturkmen72:avif_cmake

sturkmen72 commented Jan 13, 2025

Uh oh!

sturkmen72 commented Jan 13, 2025 •

edited

Loading

Uh oh!

vrabaud left a comment

Uh oh!

asmorkalov commented Jan 14, 2025

Uh oh!

sturkmen72 commented Jan 14, 2025

Uh oh!

sturkmen72 commented Jan 29, 2025

Uh oh!

hmaarrfk commented Jan 30, 2025

Uh oh!

sturkmen72 commented Jan 30, 2025

Uh oh!

Uh oh!

sturkmen72 commented Jan 30, 2025

Uh oh!

hmaarrfk commented Jan 30, 2025 •

edited

Loading

Uh oh!

sturkmen72 commented Jan 30, 2025

Uh oh!

hmaarrfk commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

sturkmen72 commented Jan 13, 2025

Pull Request Readiness Checklist

Uh oh!

sturkmen72 commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrabaud left a comment

Choose a reason for hiding this comment

Uh oh!

asmorkalov commented Jan 14, 2025

Uh oh!

sturkmen72 commented Jan 14, 2025

Uh oh!

sturkmen72 commented Jan 29, 2025

Uh oh!

hmaarrfk commented Jan 30, 2025

Uh oh!

sturkmen72 commented Jan 30, 2025

Uh oh!

Uh oh!

sturkmen72 commented Jan 30, 2025

Uh oh!

hmaarrfk commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sturkmen72 commented Jan 30, 2025

Uh oh!

hmaarrfk commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sturkmen72 commented Jan 13, 2025 •

edited

Loading

hmaarrfk commented Jan 30, 2025 •

edited

Loading