Skip to content

Move the checks to read_chunk.#26832

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
vrabaud:png
Jan 24, 2025
Merged

Move the checks to read_chunk.#26832
asmorkalov merged 1 commit intoopencv:4.xfrom
vrabaud:png

Conversation

@vrabaud
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud commented Jan 23, 2025

Only user chunks need to be compared to PNG_USER_CHUNK_MALLOC_MAX

Big PNGs with a big IDAT can fail because of this.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Only user chunks need to be compared to PNG_USER_CHUNK_MALLOC_MAX
@asmorkalov asmorkalov self-assigned this Jan 24, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 24, 2025
@asmorkalov asmorkalov merged commit 9a77bef into opencv:4.x Jan 24, 2025
asmorkalov pushed a commit that referenced this pull request Feb 13, 2025
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants