added 16-bit support to fastNlMeansDenoising and updated tests#26831
Merged
asmorkalov merged 3 commits intoopencv:4.xfrom Jan 29, 2025
Merged
added 16-bit support to fastNlMeansDenoising and updated tests#26831asmorkalov merged 3 commits intoopencv:4.xfrom
asmorkalov merged 3 commits intoopencv:4.xfrom
Conversation
asmorkalov
reviewed
Jan 27, 2025
6 tasks
Contributor
Author
|
@asmorkalov, apologies for the disturbance. If you have some time, could you please take a look at PR #26366 and share your feedback? Let me know if there's anything that needs improvement. |
Contributor
|
I reviewed the tests and they are very cryptic. I propose simpler solution: run denosing twice for the same 8bit image and 16-bit converted from 8 bit. Also I think, you can multiply 8bit input by some value, e.g.128 and denoised image should be the same as 8bit, but multiplied with the same value 128. |
Contributor
Author
|
I was about to commit :( |
Contributor
|
@shyama7004 I replaced your test with u8 vs u16 test. It's more practical rather than random input test. I'll merge the PR as soon as CI is green. |
asmorkalov
approved these changes
Jan 29, 2025
Merged
NanQin555
pushed a commit
to NanQin555/opencv
that referenced
this pull request
Feb 24, 2025
Added 16-bit support to fastNlMeansDenoising and updated tests opencv#26831 Fixes : opencv#26582 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #26582
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.