Skip to content

add CV_WRAP to Animation struct#26813

Merged
asmorkalov merged 11 commits intoopencv:4.xfrom
sturkmen72:fix_animation
Jan 22, 2025
Merged

add CV_WRAP to Animation struct#26813
asmorkalov merged 11 commits intoopencv:4.xfrom
sturkmen72:fix_animation

Conversation

@sturkmen72
Copy link
Copy Markdown
Contributor

closes #26808

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review January 21, 2025 09:53
@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 21, 2025
@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label Jan 21, 2025
@asmorkalov
Copy link
Copy Markdown
Contributor

@sturkmen72 Thanks a lot for the prompt PR! Could you add small Java test for the animations. I would say that it should be couple of simple APNG read and write cases with minimal logic. Java tests are ub modules/imgcodecs/misc/java/test. Please modules/features2d/misc/java/test as collection of examples. The tests are mostly focused on Java bindings rather than some internal C++ logic. Feel free to request support, if you are not familiar with Java.

@sturkmen72
Copy link
Copy Markdown
Contributor Author

sturkmen72 commented Jan 21, 2025

@asmorkalov i wrote a simple test ( without testing it locally ) i will improve the test according seeing test results.

@asmorkalov asmorkalov removed the pr: needs test New functionality requires minimal tests set label Jan 21, 2025
@asmorkalov asmorkalov self-assigned this Jan 21, 2025
@asmorkalov asmorkalov merged commit db962ea into opencv:4.x Jan 22, 2025
@sturkmen72 sturkmen72 deleted the fix_animation branch January 22, 2025 08:22
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
Added CV_WRAP to Animation struct opencv#26813

closes opencv#26808
### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No way to initialize the Animation class in the Java wrapper.

2 participants