Skip to content

3rdparty:ittnotify: update to v3.25.4#26802

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
Kumataro:fix26801
Jan 20, 2025
Merged

3rdparty:ittnotify: update to v3.25.4#26802
asmorkalov merged 2 commits intoopencv:4.xfrom
Kumataro:fix26801

Conversation

@Kumataro
Copy link
Copy Markdown
Contributor

Close #26801
See #26797

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro Kumataro marked this pull request as ready for review January 19, 2025 07:00
@Kumataro Kumataro mentioned this pull request Jan 19, 2025
6 tasks
@Kumataro
Copy link
Copy Markdown
Contributor Author

This patch includes supporting OpenBSD.

@brad0
Copy link
Copy Markdown
Contributor

brad0 commented Jan 19, 2025

This builds on OpenBSD/aarch64.

@Kumataro
Copy link
Copy Markdown
Contributor Author

ITT renamed from ITT_ARCH_AARCH64 to ITT_ARCH_ARM64.

#ifndef ITT_ARCH_AARCH64 /* 64-bit ARM */
# define ITT_ARCH_AARCH64 6
#endif /* ITT_ARCH_AARCH64 */

#ifndef ITT_ARCH_ARM64
# define ITT_ARCH_ARM64 6
#endif /* ITT_ARCH_ARM64 */

But both support 64bit arm architecture.

# elif defined __aarch64__
# define ITT_ARCH ITT_ARCH_AARCH64

# elif defined __aarch64__
# define ITT_ARCH ITT_ARCH_ARM64

@Kumataro
Copy link
Copy Markdown
Contributor Author

I'm sorry I noticed itt license files are renamed and updated. I fixed it.(The behavious are not effected)

@asmorkalov asmorkalov self-requested a review January 20, 2025 06:46
@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 20, 2025
@asmorkalov asmorkalov self-assigned this Jan 20, 2025
@asmorkalov asmorkalov merged commit 3e1fafe into opencv:4.x Jan 20, 2025
vrabaud pushed a commit to vrabaud/opencv that referenced this pull request Jan 21, 2025
3rdparty:ittnotify: update to v3.25.4 opencv#26802

Close opencv#26801
See opencv#26797

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
3rdparty:ittnotify: update to v3.25.4 opencv#26802

Close opencv#26801
See opencv#26797

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update 3rdparty/ittnotify to v3.25.4

4 participants