fix default cap_prop_orientation_auto behaviour#26800
Merged
asmorkalov merged 8 commits intoopencv:4.xfrom Jan 22, 2025
Merged
Conversation
asmorkalov
approved these changes
Jan 20, 2025
mshabunin
reviewed
Jan 20, 2025
ae0ed76 to
e623093
Compare
mshabunin
reviewed
Jan 21, 2025
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
There are some issues on Windows machine:
[ RUN ] videoio/VideoCaptureAPITests.mp4_orientation_default_auto/0, where GetParam() = FFMPEG
C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_orientation.cpp(53): error: Value of: cap.get(CAP_PROP_ORIENTATION_AUTO)
Actual: false
Expected: true
C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_orientation.cpp(33): error: Expected equality of these values:
width
Which is: 270
(int)cap.get(CAP_PROP_FRAME_WIDTH)
Which is: 480
C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_orientation.cpp(34): error: Expected equality of these values:
height
Which is: 480
(int)cap.get(CAP_PROP_FRAME_HEIGHT)
Which is: 270
before read frame!
after read frame!
C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_orientation.cpp(41): error: Expected equality of these values:
width
Which is: 270
frame.cols
Which is: 480
Check done!
[ FAILED ] videoio/VideoCaptureAPITests.mp4_orientation_default_auto/0, where GetParam() = FFMPEG (12 ms)
...
[ RUN ] videoio/VideoCaptureAPITests.mp4_orientation_switch/0, where GetParam() = FFMPEG
C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_orientation.cpp(33): error: Expected equality of these values:
width
Which is: 270
(int)cap.get(CAP_PROP_FRAME_WIDTH)
Which is: 480
C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_orientation.cpp(34): error: Expected equality of these values:
height
Which is: 480
(int)cap.get(CAP_PROP_FRAME_HEIGHT)
Which is: 270
before read frame!
after read frame!
C:\build\precommit_windows64\4.x\opencv\modules\videoio\test\test_orientation.cpp(41): error: Expected equality of these values:
width
Which is: 270
frame.cols
Which is: 480
before read frame!
after read frame!
[ FAILED ] videoio/VideoCaptureAPITests.mp4_orientation_switch/0, where GetParam() = FFMPEG (16 ms)
mshabunin
reviewed
Jan 21, 2025
Contributor
|
Requires CI fix first: opencv/ci-gha-workflow#213 |
mshabunin
approved these changes
Jan 22, 2025
4 tasks
Merged
NanQin555
pushed a commit
to NanQin555/opencv
that referenced
this pull request
Feb 24, 2025
…uto-default Fixed default cap_prop_orientation_auto behaviour opencv#26800 Fixes : opencv#26795 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #26795
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.