Skip to content

Ensure Obj-C header files are generated correctly if under /private/var#26713

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
homuler:fix/build-ios-framework
Jan 10, 2025
Merged

Ensure Obj-C header files are generated correctly if under /private/var#26713
asmorkalov merged 2 commits intoopencv:4.xfrom
homuler:fix/build-ios-framework

Conversation

@homuler
Copy link
Copy Markdown
Contributor

@homuler homuler commented Jan 5, 2025

Fix #26712

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@VadimLevin
Copy link
Copy Markdown
Contributor

It looks like the original issues arises due to Bazel sandboxing mechanism

Especially due to the following clause:

Bazel’s file system sandbox runs processes in a working directory that only contains known inputs, such that compilers and other tools don’t see source files they should not access, unless they know the absolute paths to them.

Can you confirm that you can reproduce the issue without using Bazel?

@homuler
Copy link
Copy Markdown
Contributor Author

homuler commented Jan 9, 2025

Yes, I can reproduce the issue as long as the OpenCV repository is located under a path that includes private.

This occurs because the file paths in src_files are absolute paths (os.path.join(root, ...)), and regular expression checks are being performed on those paths.

@asmorkalov asmorkalov self-assigned this Jan 10, 2025
@asmorkalov asmorkalov merged commit 85f9ac4 into opencv:4.x Jan 10, 2025
JSpencerPittman pushed a commit to JSpencerPittman/opencv that referenced this pull request Jan 13, 2025
Ensure Obj-C header files are generated correctly if under /private/var opencv#26713

Fix opencv#26712 

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
JSpencerPittman pushed a commit to JSpencerPittman/opencv that referenced this pull request Jan 13, 2025
Ensure Obj-C header files are generated correctly if under /private/var opencv#26713

Fix opencv#26712 

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2025
shyama7004 pushed a commit to shyama7004/opencv that referenced this pull request Jan 20, 2025
Ensure Obj-C header files are generated correctly if under /private/var opencv#26713

Fix opencv#26712 

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
Ensure Obj-C header files are generated correctly if under /private/var opencv#26713

Fix opencv#26712 

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build_xcframework.py fails if the OpenCV directory is under /private/var

4 participants